- Apr 14, 2023
-
-
Eric Engestrom authored
-
- Apr 13, 2023
-
-
This feature is supported, but enabling it accidentally enables OpenGL 3.0 & 3.1, which are not supported. The feature is enabled in main and discussion to fix the issue is underway, but we're disabling it in releases until we find a better solution. Signed-off-by: Eric Engestrom <eric@igalia.com> Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <mesa/mesa!22260>
-
To simplify both llvm and aco backend and remove unnecessary workaround code where prim count is known to be not zero. Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!22381>
-
Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!22437>
-
Signed-off-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!22437>
-
rustfmt has some magic that follows files (I'm guessing), making files get checked multiple times with `*.rs`, so let's limit ourselves to `lib.rs`. Part-of: <mesa/mesa!22321>
-
Per [1], arm is for 32-bit. For an upcoming change, we need to detect AArch64 specifically. Specifying arm in the cross file will result in the wrong build script behavior. [1]: https://mesonbuild.com/Reference-tables.html#cpu-families Reviewed-by: Helen Koike <helen.koike@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!22418>
-
Part-of: <mesa/mesa!22453>
-
For the CL spec it really matters how a program object was created. We never really cared all that much, but it didn't support the corner case of having an empty string as the OpenCL C source code. Enums feel like the more Rust way to do this kind of stuff anyway. Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
The code wasn't all the same, but the build version was wrong, e.g. the compile flags specified need to be stored even on error. Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Closes: mesa/mesa#8771 Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <!22280>
-
We want to validate the actual passed in SPIR-V, but we can only report errors back on build/compile time. So instead of storing the initial IL in the devices `ProgramBuild` objects, just store it on the Program instead. This also simplifies setting spec constants as this is only valid on program directly created from IL and not e.g. linked ones. Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <mesa/mesa!22280>
-
I moved to many things to radv_pipeline_graphics.c without checking. Fixes: 7783b7f6 ("radv: split radv_pipeline.c into radv_pipeline_{compute,graphics}.c") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!22441>
-
Reviewed-by: Marek Olšák <marek.olsak@amd.com> Signed-off-by: Vitaliy Triang3l Kuzmin <triang3l@yandex.ru> Part-of: <mesa/mesa!22384>
-
Noticed while debugging OpenCL. I think this was fallout from the CSF decode rework? Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Italo Nicola <italonicola@collabora.com> Part-of: <mesa/mesa!22228>
-
In OpenCL, we can have no shader-defined shared memory but some dispatch-time variable memory. This is not reflected in ss->info.wls_size, so check the right variable instead so we allocate the appropriate memory. Fixes page faults accessing shared memory with Rusticl, e.g. in the vstore_local test. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Italo Nicola <italonicola@collabora.com> Part-of: <mesa/mesa!22228>
-
OpenCL can generate large loads and stores that we can't support, so we need to lower. We can load/store up to 128-bits in a single go. We currently only handle up to 32-bit components in the load and no more than vec4, so we split up accordingly. It's not clear to me what the requirements are for alignment on Valhall, so we conservatively generate aligned access, at worst there's a performance penalty in those cases. I think unaligned access is suppoerted, but likely with a performance penalty of its own? So in the absence of hard data otherwise, let's just use natural alignment. Oddly, this shaves off a tiny bit of ALU in a few compute shaders on Valhall, all in gfxbench. Seems to just be noise from the RA lottery. total instructions in shared programs: 2686768 -> 2686756 (<.01%) instructions in affected programs: 584 -> 572 (-2.05%) helped: 6 HURT: 0 Instructions are helped. total cvt in shared programs: 14644.33 -> 14644.14 (<.01%) cvt in affected programs: 5.77 -> 5.58 (-3.25%) helped: 6 HURT: 0 total quadwords in shared programs: 1455320 -> 1455312 (<.01%) quadwords in affected programs: 56 -> 48 (-14.29%) helped: 1 HURT: 0 Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!22228>
-
We need to respect the ALU swizzle, this takes a vector. Fixes incorrect pack_64_2x32 translation hit when wiring up lower_mem_access_bit_sizes for OpenCL. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!22228>
-
With OpenCL we can generate stuff like CSEL.u32.eq r0.b0000, we need to handle it when lowering swizzles. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <!22228>
-
Based on vkQueuePresentKHR calls. It just helps spotting the beginning end of a frame in perfetto when apps are using 3/4 command buffers per frame. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!22276>
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!22276>
-
The query buffer contains a batch to implement the multi pass replay/accumulation of results. So we can't clear it with a memset. An optimization for later would be to move the batches to the very end of the query buffer so we can clear the query data without touching the batches. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 4dc7256b ("anv: reset query pools using blorp") Reviewed-by: Felix DeGrood <felix.j.degrood@intel.com> Part-of: <mesa/mesa!22421>
-
- Apr 12, 2023
-
-
Primitive export used the gs_accepted variable after culling, so we overwrote this variable after vertex compaction to make sure not to hang the GPU. This had an unintended side effect when storing the primitive ID to LDS on GS threads: the LDS store was done even on threads whose triangle was culled; potentially causing issues. As a fix, create a separate boolean variable that remembers which invocations need to export a primitive; and don't store the primitive ID to LDS when gs_accepted is false. Cc: mesa-stable Closes: mesa/mesa#8805 Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Qiang Yu <yuq825@gmail.com> Part-of: <mesa/mesa!22424>
-
skip_frame_enable is for preventing overshooting in some cases, however the tests in FW were broken, and the output result shows the functionality has not completed yet, which is the reason this should be disabled at the moment until it has been fully verified. Cc: mesa-stable Fixes: mesa/mesa#8178 Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com> Signed-off-by: Ruijing Dong <ruijing.dong@amd.com> Part-of: <mesa/mesa!22428>
-
Fixes: 37a8b2d1 Closes: #8727 Signed-off-by: Oleksii Bozhenko <oleksii.bozhenko@globallogic.com> Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Eric Engestrom <eric@igalia.com> Part-of: <!22337>
-
Signed-off-by: Oleksii Bozhenko <oleksii.bozhenko@globallogic.com> Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by: Eric Engestrom <eric@igalia.com> Part-of: <!22337>
-
when a new resource is created for an extant swapchain, the existing acquire (if any) should be transferred to the resource to ensure expected behavior this should be enough to fix piglit's glx-make-current Part-of: <mesa/mesa!22431>
-
this is important for handing off the swapchain between resources on makecurrent since a context that is made not-current will have its swapchain resources destroyed while the swapchain persists Part-of: <mesa/mesa!22431>
-
Fixes: 9ee67467 ("radv: predicate cmask eliminate when using DCC.") Part-of: <mesa/mesa!22392>
-
Fixes: 9ee67467 ("radv: predicate cmask eliminate when using DCC.") Part-of: <mesa/mesa!22392>
-
Fixes: 4c6f8300 ("radv: Synchronization for task shaders.") Part-of: <mesa/mesa!22392>
-
Fixes: e45ba51e ("radv: add support for VK_EXT_conditional_rendering") Part-of: <mesa/mesa!22392>
-
Fixes: b4eb0290 ("radv: implement VK_EXT_transform_feedback") Part-of: <mesa/mesa!22392>
-
In the execute secondary scenario nothing else does it for us. Fixes: 203f60eb ("radv: emit framebuffer state from primary if secondary doesn't inherit it") Part-of: <mesa/mesa!22392>
-