Skip to content

RFC: On removing refcounting from stereo camera calib struct

Mateo de Mayo requested to merge mateosss/monado:mateosss/camcalib-no-refcount into main

Why are we refcounting t_stereo_camera_calib?

We have t_imu_calib (~288 bytes) and t_stereo_camera_calib (~706 bytes) which are pretty similar but one of them is reference counted. This makes it slightly more annoying to use when we could just be passing the struct by value instead as it's not that big and, from my understanding it's not used in any hot path in Monado.

Do we want to support platforms with limitations on stack size? If so what would be a good threshold size to determine if a struct should be refcounted? Would it be ok if I just remove refcounting from t_stereo_camera_calib?

Merge request reports