Skip to content

tests: disable OpenGL client compositor test if GLX is not present

Simon Zeni requested to merge bl4ckb0ne/monado:tests-glx into main

Fixes the behaviour introduces in !1465 (merged)

tests_comp_client_opengl has an undefined reference to a symbol only activated if GLX is present

ninja: job failed: : && /usr/bin/c++ -pedantic -Wall -Wextra -Wno-unused-parameter -g  tests/CMakeFiles/tests_comp_client_opengl.dir/
tests_comp_client_opengl.cpp.o -o tests/tests_comp_client_opengl  -Wl,-rpath,/usr/local/lib  tests/libtests_main.a  src/xrt/auxiliary
/util/libaux_util.a  src/xrt/compositor/libcomp_client.a  src/xrt/compositor/libcomp_mock.a  src/xrt/auxiliary/ogl/libaux_ogl.a  /usr
/lib/libSDL2main.a  /usr/lib/libSDL2-2.0.so.0.2400.0  /usr/local/lib/libEGL.so  src/xrt/auxiliary/vk/libaux_vk.a  src/xrt/auxiliary/o
s/libaux_os.a  -ldbus-1  /usr/lib/libvulkan.so  src/xrt/auxiliary/util/libaux_util.a  src/xrt/auxiliary/math/libaux_math.a  src/xrt/a
uxiliary/util/libaux_util.a  src/xrt/auxiliary/math/libaux_math.a  src/xrt/auxiliary/bindings/libaux_generated_bindings.a  /usr/lib/l
ibjpeg.so && :                                                                                                                       
/usr/lib/gcc/x86_64-alpine-linux-musl/12.1.1/../../../../x86_64-alpine-linux-musl/bin/ld: tests/CMakeFiles/tests_comp_client_opengl.d
ir/tests_comp_client_opengl.cpp.o: in function `C_A_T_C_H_T_E_S_T_0()':                                                              
/home/simon/src/monado/tests/tests_comp_client_opengl.cpp:68: undefined reference to `client_gl_xlib_compositor_create' 

My system has XCB and XLIB but not GLX

-- #####----- Config -----#####                                                                                                      
-- #    GIT_DESC:        v21.0.0-2384-gedd1aa0d                                                                                      
-- #                                                                                                                                 
-- #    BLUETOOTH:       OFF                                                                                                         
-- #    BASALT:          OFF                                                                                                         
-- #    D3D11:           OFF                                                                                                         
-- #    DBUS:            ON                                                                                                          
-- #    EGL:             ON                                                                                                          
-- #    FFMPEG:          ON                                                                                                          
-- #    GST (GStreamer): ON                                                                                                          
-- #    HIDAPI:          ON                                                                                                          
-- #    JPEG:            ON                                                                                                          
-- #    KIMERA:          OFF                                                                                                         
-- #    LIBBSD:          OFF                                                                                                         
-- #    LIBUSB:          ON                                                                                                          
-- #    LIBUVC:          OFF                                                                                                         
-- #    ONNXRUNTIME:     ON                                                                                                          
-- #    OPENCV:          ON                                                                                                          
-- #    OPENGL:          ON                                                                                                          
-- #    OPENGLES:        ON                                                                                                          
-- #    OPENGL_GLX:      OFF                                                                                                         
-- #    PERCETTO:        OFF                                                                                                         
-- #    REALSENSE:       OFF                                                                                                         
-- #    SDL2:            ON                                                                                                          
-- #    SLAM:            OFF                                                                                                         
-- #    SYSTEM_CJSON:    OFF                                                                                                         
-- #    SYSTEMD:         OFF                                                                                                         
-- #    VULKAN:          ON                                                                                                          
-- #    WAYLAND:         ON                                                                                                          
-- #    WAYLAND_DIRECT:  ON                                                                                                          
-- #    XCB:             ON                                                                                                          
-- #    XLIB:            ON                                                                                                          
-- #    XRANDR:          ON

Merge request reports