Skip to content

feat: add optional parameters to UIM operations to enable dual SIM PIN unlocking

Jonas K requested to merge i-tek/libqmi:feat/multi_slot_pin_verification into main

Adds optional key-value-pair parameters to the actions that regard the SIM PIN. These are:

DELETED DUE TO SPAM FILTER

Purpose of change

I propose adding additional optional(!) key-value-pair parameters to these actions because dual SIM setups weren't able to unlock the SIM PIN of other SIM slots. This is due to a hardcoded card-slot-1 in all SIM PIN related actions in qmicli. By using additional parameters to specify the session_type it becomes possible to identify the "SIM to unlock" by its slot id or even by the currently provisioned primary GW.

This implementation should be fully backwards compatible, as the session_type specification is completely optional. If it is not specified the card-slot-1 will be used as before.

Despite the backwards compatibility, using optional key-value-pairs also allows flexibility with regard to future development.

ToDo

  • squash commits
  • test on target

Future work

I have seen that a similar issue exists for the SIM card application IDs. Currently the ID is hardcoded to the first application ID.

Test results

DELETED DUE TO SPAM FILTER - again

See comment !378 (comment 2333892) which obviously is not spam filtered.

Edited by Jonas K

Merge request reports