[PATCH] add support for PIN handling in mbim-network

Submitted by Jaroslav Stepanek

Assigned to Aleksander Morgado

Link to original bug (#101268)

Description

Created attachment 131633 PIN.patch

The current version of mbim-network doesn't handle PIN. This patch adds support vi a an optional PIN keyword in the config file.

Patch 131633, "PIN.patch":
PIN.patch

Aleksander Morgado commented on patch 131633:

Review of attachment 131633:

Hey, thanks for the patch, see comments inline.

::: /usr/bin/mbim-network @@ +70,5 @@

 echo "   in the profile:"
 echo "      PROXY=yes"
 echo

• echo " 7) If your SIM card is PIN locked, you can supply the pin"
• echo " like this in the config file"

in the profile:

@@ +195,5 @@

     else
         echo "    mbim-proxy: no"
     fi

• if [ -n "$PIN" ]; then

Looks like there's a TAB before the if []; we are indenting with spaces here.

@@ +266,4 @@

     clear_state
 fi

• if [ -n "$PIN" ]; then

how about storing the command to run in a variable so that we can print it as well in a message, as done in e.g. SUBSCRIBER_READY_CMD below?

@@ +266,5 @@

     clear_state
 fi

• if [ -n "$PIN" ]; then

•    mbimcli -d $DEVICE --enter-pin=$PIN

missing: --no-close $PROXY_OPT

Jaroslav Stepanek submitted a patch:

better like this? sorry for the tab, vim got it wrong:-(

Patch 131639, "patch v2":
PIN_v2.patch

Aleksander Morgado commented on patch 131639:

Review of attachment 131639:

I see the diff is done against /usr/bin/mbim-network... would you be willing to provide a proper git patch against the libmbim git repository instead? If you cannot or you don't want, let me know and I'll manually apply the changes myself.

::: /usr/bin/mbim-network @@ +269,5 @@

• if [ -n "$PIN" ]; then

•    UNLOCK_SIM_CMD="mbimcli -d $DEVICE --enter-pin=$PIN --no-close $PROXY_OPT"

•    echo "Unlocking SIM card with PIN code '$UNLOCK_SIM_CMD'..."

•    UNLOCK_SIM_OUT=`$UNLOCK_SIM_CMD`

•    echo $UNLOCK_SIM_OUT

Instead of always printing the UNLOCK_SIM_OUT, we should probably detect whether the unlock attempt succeeded or not, and print the full response only if it failed, e.g.:

UNLOCK_SIM_OUT=`$UNLOCK_SIM_CMD`
if [ $? -eq 0 ]; then
    echo "SIM-PIN unlocked successfully"
else
    echo "SIM-PIN unlock failed"
    echo $UNLOCK_SIM_OUT
fi

What do you think?

Jaroslav Stepanek said:

I will post a proper git patch, just have to RTFM how as I've never done it before...

Same for the other patch for the help switch.

As for the proposed changes to the pin change detection, I am all for it.

I didn't like the way how the libmbim commands are always sent so I created a refactored version using a dispatcher function. I is much nicer to use, but I am still ironing out some edge use cases. Will post it as soon as it is ready.

Aleksander Morgado said:

I didn't like the way how the libmbim commands are always sent so I created a refactored version using a dispatcher function. I is much nicer to use, but I am still ironing out some edge use cases. Will post it as soon as it is ready.

I'm not sure what you mean, but I'd suggest you post it either in bugzilla or in the libmbim-mailing list first as a RFC to see what everyone says about those changes ;)

mentioned in commit ef133a7a

mentioned in commit cf730562

added LOW label

removed bugzilla label

mentioned in commit dcde5319

mentioned in commit dfaee1e7

mentioned in merge request !185 (merged)

mentioned in commit dcbw/libqmi@ef33322a