Skip to content

broadband-modem-mbim: parse nw_error in register_state_set_ready only if MBIM_STATUS_FAILURE

Aleksander Morgado requested to merge aleksm/ModemManager:mbim-nwerror into master

Some modems (Namely: Telit LE910 V2) report nonzero NwError code, outside of 3GPP TS 24.008 - in "register-state set command-done" response, while status code equals MBIM_STATUS_ERROR_NONE. In such cases network is operational. According to MBIM specification 1.0 table 10.5.9.8 "Status codes", NwError shall be nonzero only if Status Code equals MBIM_STATUS_FAILURE, and client shall parse NwError only in such cases. Also, MBIM specification does not explicitly state that 'NwError == 0' equals no error, rather than that it is unknown error, hence raise an error unconditionally if MBIM status code is MBIM_STATUS_FAILURE.

Therefore, check NwError IFF MBIM response status code equals MBIM_STATUS_FAILURE, instead of MBIM_STATUS_SUCCESS.

Fixes: 854c371c ("broadband-modem-mbim: implement 3GPP registration request") Signed-off-by: Lech Perczak l.perczak@camlintechnologies.com

Merge request reports