Skip to content
Snippets Groups Projects

base-call: Increase incoming call timeout to ten seconds

Merged Bob Ham requested to merge rah/ModemManager:rah/base-call-o2-timeout-fix into master

The standard says a RING or CRING should be emitted whenever the network sends an incoming call notification, which is nation-specific:

"Interpretation of indications from the network to determine what constitutes a "ring" is defined by national regulations. This result code should be repeated each time the network repeats the incoming call indication." -- ITU-T Rec. V.250, p. 42

On the giffgaff (O2) network in the UK, a SIMCom SIM7100E modem emits RING indicators every six seconds. The current timeout is only five seconds resulting in a stream of timed-out ModemManager call objects whenever there is an incoming call. To fix this, we increase the timeout to ten seconds.

Edited by Bob Ham

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bob Ham restored source branch rah/base-call-o2-timeout-fix

    restored source branch rah/base-call-o2-timeout-fix

  • How about just 10s instead? I don't recall right now, what would be the implication of updating this value to a greater value? Isn't it just to track calls that are "alive" (e.g. when no more rings received, we consider the call missed)?

  • Bob Ham added 1 commit

    added 1 commit

    • cce53e15 - base-call: Increase incoming call timeout to ten seconds

    Compare with previous version

  • That's what it is, yes:

    /* Incoming calls are reported via RING URCs. If the caller stops the call
     * attempt before it has been answered, the only thing we would see is that the
     * URCs are no longer received. So, we will start a timeout whenever a new RING
     * URC is received, and we refresh the timeout any time a new URC arrives. If
     * the timeout is expired (meaning no URCs were received in the last N seconds)
     * then we assume the call attempt is finished and we transition to TERMINATED.
     */

    I've updated the patch to increase it to ten seconds.

  • Bob Ham changed title from base-call: Increase incoming call timeout to seven seconds to base-call: Increase incoming call timeout to ten seconds

    changed title from base-call: Increase incoming call timeout to seven seconds to base-call: Increase incoming call timeout to ten seconds

  • Bob Ham changed the description

    changed the description

  • Bob Ham added 2 commits

    added 2 commits

    • 318d4535 - 1 commit from branch mobile-broadband:master
    • 1cee215f - base-call: Increase incoming call timeout to ten seconds

    Compare with previous version

Please register or sign in to reply
Loading