Skip to content

Fix handling of multi-sentence NMEA messages

Teemu Ikonen requested to merge tpikonen/ModemManager:multi-nmea into master

Some devices (I have Quectel EG25 in a Pinephone) support multiple constellations (Galileo, Glonass etc.) and output NMEA sentences with talker prefixes corresponding to these (GL, GN, GA and so on). ModemManager has code to append multi-sentence NMEA sentences to a list, but currently only GSV messsages from GPS (GPGSV) are appended. For other multi-sentence messages only the last sentence can be obtained through the MM API.

This MR fixes the regexp in check_append_or_replace() to accept

  1. more multi-sentence NMEA messages (ALM, GSV, RTE, SFI)
  2. multi-sentence NMEA messages from all talkers, not just GPS (i.e. GPGSV, GLGSV, GAGSV etc.)

Merge request reports