Skip to content

WIP: port-serial: avoid unhooking a signal on finalize()

Lubomir Rintel requested to merge lkundrak/ModemManager:lr/serial-close-signal into master

By then GLib would have disconnected it, causing an warning on another attempt:

  #0  0x00007ffff64ab5f5 in _g_log_abort (breakpoint=1) at gmessages.c:580
  #1  0x00007ffff64ac90d in g_logv (log_domain=0x7ffff67ad084 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=args@entry=0x7fffffffd2f0) at gmessages.c:1391
  #2  0x00007ffff64acae3 in g_log (log_domain=log_domain@entry=0x7ffff67ad084 "GLib-GObject", log_level=log_level@entry=G_LOG_LEVEL_WARNING, format=format@entry=0x7ffff67b2078 "%s: instance '%p' has no handler with id '%lu'")
      at gmessages.c:1432
  #3  0x00007ffff67939c7 in g_signal_handler_disconnect (instance=instance@entry=0x555555937380, handler_id=113) at gsignal.c:2641
  #4  0x0000555555634468 in _close_internal (self=self@entry=0x555555937380 [MMPortSerialAt], force=force@entry=1) at mm-port-serial.c:1390
  #5  0x0000555555634676 in port_serial_close_force (self=0x555555937380 [MMPortSerialAt]) at mm-port-serial.c:1523
  #6  0x0000555555634676 in port_serial_close_force (self=0x555555937380 [MMPortSerialAt]) at mm-port-serial.c:1504
  #7  0x0000555555634de8 in finalize (object=0x555555937380 [MMPortSerialAt]) at mm-port-serial.c:2060
  #8  0x00007ffff67868a9 in g_object_unref (_object=<optimized out>) at gobject.c:3340
  ...
Edited by Aleksander Morgado

Merge request reports