cli/mmcli-modem-signal.c

@@ -140,7 +140,7 @@ print_signal_value (const gchar *prefix,
     if (value != MM_SIGNAL_UNKNOWN)
         g_print ("%s'%.2lf' %s\n", prefix, value, units);
     else
-        g_print ("%sn/a\n", prefix);
+        g_print ("%s'n/a'\n", prefix);
 }
 
 static void
@@ -175,8 +175,10 @@ print_signal_info (void)
 
     /* GSM */
     signal = mm_modem_signal_peek_gsm (ctx->modem_signal);
-    if (signal)
+    if (signal) {
+        g_print ("  -------------------------\n");
         print_signal_value ("  GSM    | RSSI: ", mm_signal_get_rssi (signal), "dBm");
+    }
 
     /* UMTS */
     signal = mm_modem_signal_peek_umts (ctx->modem_signal);

docs/reference/libmm-glib/libmm-glib-sections.txt

@@ -476,8 +476,6 @@ mm_location_3gpp_get_mobile_network_code
 mm_location_3gpp_get_location_area_code
 mm_location_3gpp_get_tracking_area_code
 mm_location_3gpp_get_cell_id
-<SUBSECTION Methods>
-mm_location_3gpp_reset
 <SUBSECTION Private>
 mm_location_3gpp_get_string_variant
 mm_location_3gpp_new
@@ -487,6 +485,7 @@ mm_location_3gpp_set_location_area_code
 mm_location_3gpp_set_tracking_area_code
 mm_location_3gpp_set_mobile_country_code
 mm_location_3gpp_set_mobile_network_code
+mm_location_3gpp_reset
 <SUBSECTION Standard>
 MMLocation3gppClass
 MMLocation3gppPrivate
@@ -1324,40 +1323,10 @@ MM_TYPE_CALL_PROPERTIES
 mm_call_properties_get_type
 </SECTION>
 
-<SECTION>
-<FILE>mm-call-audio-format</FILE>
-<TITLE>MMCallAudioFormat</TITLE>
-MMCallAudioFormat
-<SUBSECTION GettersSetters>
-mm_call_audio_format_get_encoding
-mm_call_audio_format_get_resolution
-mm_call_audio_format_get_rate
-<SUBSECTION Private>
-mm_call_audio_format_new
-mm_call_audio_format_new_from_dictionary
-mm_call_audio_format_get_dictionary
-mm_call_audio_format_dup
-mm_call_audio_format_set_encoding
-mm_call_audio_format_set_resolution
-mm_call_audio_format_set_rate
-<SUBSECTION Standard>
-MMCallAudioFormatClass
-MMCallAudioFormatPrivate
-MM_IS_CALL_AUDIO_FORMAT
-MM_IS_CALL_AUDIO_FORMAT_CLASS
-MM_CALL_AUDIO_FORMAT
-MM_CALL_AUDIO_FORMAT_CLASS
-MM_CALL_AUDIO_FORMAT_GET_CLASS
-MM_TYPE_CALL_AUDIO_FORMAT
-mm_call_audio_format_get_type
-</SECTION>
-
 <SECTION>
 <FILE>mm-pco</FILE>
 <TITLE>MMPco</TITLE>
 MMPco
-<SUBSECTION New>
-mm_pco_new
 <SUBSECTION GettersSetters>
 mm_pco_get_session_id
 mm_pco_is_complete
@@ -1366,6 +1335,7 @@ mm_pco_get_data
 mm_pco_list_add
 mm_pco_list_free
 <SUBSECTION Private>
+mm_pco_new
 mm_pco_from_variant
 mm_pco_to_variant
 mm_pco_set_session_id

libmm-glib/mm-bearer-properties.c

@@ -408,16 +408,6 @@ mm_bearer_properties_get_dictionary (MMBearerProperties *self)
 
 /*****************************************************************************/
 
-
-/**
- * mm_bearer_properties_consume_string:
- * @self: a #MMBearerProperties
- * @key: the key string.
- * @value: the value string.
- * @error: (allow-none): Return location for error or %NULL.
- *
- * Returns: %TRUE if the operation succeeded, %FALSE if @error is set.
- */
 gboolean
 mm_bearer_properties_consume_string (MMBearerProperties *self,
                                      const gchar *key,
@@ -527,15 +517,6 @@ mm_bearer_properties_new_from_string (const gchar *str,
 
 /*****************************************************************************/
 
-/**
- * mm_bearer_properties_consume_variant:
- * @properties: a #MMBearerProperties
- * @key: the key string.
- * @value: a #GVariant
- * @error: (allow-none): Return location for error or %NULL.
- *
- * Returns: %TRUE if the operation succeeded, %FALSE if @error is set.
- */
 gboolean
 mm_bearer_properties_consume_variant (MMBearerProperties *properties,
                                       const gchar *key,

libmm-glib/mm-modem-3gpp.c

@@ -652,6 +652,16 @@ mm_modem_3gpp_scan_sync (MMModem3gpp *self,
 
 /*****************************************************************************/
 
+/**
+ * mm_modem_3gpp_set_eps_ue_mode_operation_finish:
+ * @self: A #MMModem3gpp.
+ * @res: The #GAsyncResult obtained from the #GAsyncReadyCallback passed to mm_modem_3gpp_set_eps_ue_mode_operation().
+ * @error: Return location for error or %NULL.
+ *
+ * Finishes an operation started with mm_modem_3gpp_set_eps_ue_mode_operation().
+ *
+ * Returns: %TRUE if the operation was successful, %FALSE if @error is set.
+ */
 gboolean
 mm_modem_3gpp_set_eps_ue_mode_operation_finish (MMModem3gpp   *self,
                                                 GAsyncResult  *res,
@@ -662,6 +672,24 @@ mm_modem_3gpp_set_eps_ue_mode_operation_finish (MMModem3gpp   *self,
     return mm_gdbus_modem3gpp_call_set_eps_ue_mode_operation_finish (MM_GDBUS_MODEM3GPP (self), res, error);
 }
 
+/**
+ * mm_modem_3gpp_set_eps_ue_mode_operation:
+ * @self: A #MMModem3gpp.
+ * @mode: A #MMModem3gppEpsUeModeOperation.
+ * @cancellable: (allow-none): A #GCancellable or %NULL.
+ * @callback: A #GAsyncReadyCallback to call when the request is satisfied or %NULL.
+ * @user_data: User data to pass to @callback.
+ *
+ * Asynchronously requests to update the EPS UE mode of operation.
+ *
+ * When the operation is finished, @callback will be invoked in the
+ * <link linkend="g-main-context-push-thread-default">thread-default main loop</link>
+ * of the thread you are calling this method from. You can then call
+ * mm_modem_3gpp_set_eps_ue_mode_operation_finish() to get the result of the operation.
+ *
+ * See mm_modem_3gpp_set_eps_ue_mode_operation_sync() for the synchronous, blocking
+ * version of this method. The calling thread is blocked until a reply is received.
+ */
 void
 mm_modem_3gpp_set_eps_ue_mode_operation (MMModem3gpp                    *self,
                                          MMModem3gppEpsUeModeOperation   mode,
@@ -675,6 +703,21 @@ mm_modem_3gpp_set_eps_ue_mode_operation (MMModem3gpp                    *self,
     mm_gdbus_modem3gpp_call_set_eps_ue_mode_operation (MM_GDBUS_MODEM3GPP (self), (guint) mode, cancellable, callback, user_data);
 }
 
+/**
+ * mm_modem_3gpp_set_eps_ue_mode_operation_sync:
+ * @self: A #MMModem3gpp.
+ * @mode: A #MMModem3gppEpsUeModeOperation.
+ * @cancellable: (allow-none): A #GCancellable or %NULL.
+ * @error: Return location for error or %NULL.
+ *
+ * Synchronously requests to update the EPS UE mode of operation.
+ *
+ * The calling thread is blocked until a reply is received.
+ * See mm_modem_3gpp_set_eps_ue_mode_operation() for the asynchronous version
+ * of this method.
+ *
+ * Returns: %TRUE if the operation was successful, %FALSE if @error is set.
+ */
 gboolean
 mm_modem_3gpp_set_eps_ue_mode_operation_sync (MMModem3gpp                    *self,
                                               MMModem3gppEpsUeModeOperation   mode,

plugins/dell/77-mm-dell-port-types.rules

@@ -10,11 +10,11 @@ SUBSYSTEMS=="usb", ATTRS{bInterfaceNumber}=="?*", ENV{.MM_USBIFNUM}="$attr{bInte
 
 # Dell DW5821e
 #  if 02: primary port
-#  if 03: secondary port (ignore)
+#  if 03: secondary port
 #  if 04: raw NMEA port
 #  if 05: diag/qcdm port
 ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81d7", ENV{.MM_USBIFNUM}=="02", ENV{ID_MM_PORT_TYPE_AT_PRIMARY}="1"
-ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81d7", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_PORT_IGNORE}="1"
+ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81d7", ENV{.MM_USBIFNUM}=="03", ENV{ID_MM_PORT_TYPE_AT_SECONDARY}="1"
 ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81d7", ENV{.MM_USBIFNUM}=="04", ENV{ID_MM_PORT_TYPE_GPS}="1"
 ATTRS{idVendor}=="413c", ATTRS{idProduct}=="81d7", ENV{.MM_USBIFNUM}=="05", ENV{ID_MM_PORT_TYPE_QCDM}="1"