1. 03 Feb, 2023 2 commits
  2. 30 Jan, 2023 4 commits
  3. 27 Jan, 2023 1 commit
  4. 23 Jan, 2023 1 commit
    • Louis-Alexis Eyraud's avatar
      broadband-modem-qmi: don't fail on power indication registration error · 6006dd1d
      Louis-Alexis Eyraud authored and Aleksander Morgado's avatar Aleksander Morgado committed
      This commit modifies the QMI DMS Operating Mode indication registration logic.
      During the power sequence chance, if a QMI_PROTOCOL_ERROR_MISSING_ARGUMENT error
      was returned in "DMS Set Event Report" operation for Operating Mode Reporting failed,
      the whole sequence was aborted, leading the modem to be disabled.
      
      <debug> [modem0] Power indication registration request is sent
      ...
      <debug> [modem0] couldn't update power state: Couldn't register for power indications: QMI protocol error (17): 'MissingArgument'
      <warn>  [modem0] couldn't enable interface: 'Couldn't register for power indications: QMI protocol error (17): 'MissingArgument''
      <debug> [modem0] running implicit disable after failed enable...
      
      This commit modifies the logic to properly detect the failure and
      continue the sequence without the indications.
      
      Fixes #683
      
      
      
      Signed-off-by: Louis-Alexis Eyraud's avatarLouis-Alexis Eyraud <louis-alexis.eyraud@unabiz.com>
      6006dd1d
  5. 22 Jan, 2023 1 commit
  6. 20 Jan, 2023 1 commit
    • Lubomir Rintel's avatar
      bearer-qmi: fix a mnc/mcc typo · 3a1cc27f
      Lubomir Rintel authored
      Makes my compiler unhappy:
      
        [471/539] Compiling C object src/ModemManager.p/mm-bearer-qmi.c.o
        ../src/mm-bearer-qmi.c: In function ‘process_operator_reserved_pco’:
        ../src/mm-bearer-qmi.c:580:18: warning: logical ‘and’ of equal expressions [-Wlogical-op]
          580 |     if (!tmp_mcc && !tmp_mcc && !container_id && !array->len)
              |                  ^~
      
      Fixes: f4b8d14b ('bearer-qmi: explicitly ignore PCOs with undefined contents:')
      3a1cc27f
  7. 18 Jan, 2023 7 commits
  8. 16 Jan, 2023 2 commits
    • Aleksander Morgado's avatar
      bearer-qmi: explicitly ignore PCOs with undefined contents: · f4b8d14b
      Aleksander Morgado authored
      There is nothing to process in this kind of PCO fields:
      
        <<<<<< TLV:
        <<<<<<   type       = "Operator Reserved PCO" (0x2f)
        <<<<<<   length     = 8
        <<<<<<   value      = 00:00:00:00:00:00:00:00
        <<<<<<   translated = [ mcc = '0' mnc = '0' mnc_includes_pcs_digit = 'no' app_specific_info = '{}' container_id = '0' ]
      
      Fixes #690
      f4b8d14b
    • Aleksander Morgado's avatar
      bearer-qmi: app specific info in PCO may be empty · cf59b497
      Aleksander Morgado authored
        ModemManager[562783]: <err> [1673538458.350130] mm_utils_bin2hexstr: assertion 'bin != NULL' failed
        ModemManager[562783]: <dbg> [1673538458.350167] [modem0/bearer0] container ID: 0
        ModemManager[562783]: <dbg> [1673538458.350201] [modem0/bearer0] app specific info: (null)
      
      Treat it better by only trying to build the app specific info string
      if there are contents in the array.
      cf59b497
  9. 12 Jan, 2023 1 commit
  10. 11 Jan, 2023 2 commits
  11. 10 Jan, 2023 1 commit
  12. 09 Jan, 2023 1 commit
  13. 03 Jan, 2023 16 commits