- Jul 05, 2023
-
-
Sune Vuorela authored
-
- Jul 04, 2023
-
-
Jan-Michael Brummer authored
Remove #ifdef and error handling Fixes: poppler/poppler#1412
-
- Jul 03, 2023
-
-
Albert Astals Cid authored
-
Albert Astals Cid authored
-
Anton Thomasson authored
Fixes #1395
-
Albert Astals Cid authored
-
Sune Vuorela authored
-
- Jun 30, 2023
-
-
Sune Vuorela authored
-
Jan-Michael Brummer authored
-
- Jun 29, 2023
-
-
Albert Astals Cid authored
-
Sune Vuorela authored
Hopefully fixes #1408
-
Jan-Michael Brummer authored
Rectangle corrections by Marek Kasik
-
- Jun 28, 2023
-
-
Albert Astals Cid authored
-
- Jun 27, 2023
-
-
Albert Astals Cid authored
-
Sune Vuorela authored
-
Albert Astals Cid authored
Fixes KDE Bug #471422
-
- Jun 26, 2023
-
-
Kevin Ottens authored
When overprint preview is enabled, the image data row size changes during conversion to XBGR. The Qt bindings were assuming this row size was constant which led to badly broken QImages at conversion time (generating garbage if displayed or even crashing). This commit simply add regression tests for the case and gets the row size after bitmap conversion.
-
- Jun 16, 2023
-
-
Albert Astals Cid authored
-
Sune Vuorela authored
Document how the backends interacts with the OCSP and AIA flags, and ensure the implementation matches.
-
Oliver Sander authored
This simplifies the code, and saves a few heap allocations.
-
Oliver Sander authored
Rather than as a pointer to a GooString Safer and simpler code, and less memory allocations.
-
Oliver Sander authored
Rather than storing a pointer and allocating the std::vector on the heap. This simplifies the code and saves a few heap allocations.
-
Even Rouault authored
Fixes a regression introduced by recent 9183da4f commit which caused the following Valgrind error: ``` $ valgrind utils/pdftoppm /tmp/test.pdf ==3735668== Memcheck, a memory error detector ==3735668== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==3735668== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info ==3735668== Command: utils/pdftoppm /tmp/test.pdf ==3735668== Syntax Warning: May not be a PDF file (continuing anyway) Syntax Error: Unterminated string ==3735668== Invalid write of size 2 ==3735668== at 0x4A3570C: utf8ToUtf16(char const*, unsigned short*, int, int) (poppler/UTF.cc:353) ==3735668== by 0x4A3584C: utf8ToUtf16(char const*, int*) (poppler/UTF.cc:368) ==3735668== by 0x4A358D4: utf8ToUtf16WithBom(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (poppler/UTF.cc:379) ==3735668== by 0x49F2C97: Lexer::getObj(int) (poppler/Lexer.cc:424) ==3735668== by 0x4A035C2: Parser::Parser(XRef*, Stream*, bool) (poppler/Parser.cc:50) ==3735668== by 0x49F888B: Linearization::Linearization(BaseStream*) (poppler/Linearization.cc:28) ==3735668== by 0x4A06D8D: getLinearization (poppler/PDFDoc.cc:648) ==3735668== by 0x4A06D8D: PDFDoc::isLinearized(bool) (poppler/PDFDoc.cc:700) ==3735668== by 0x4A0518D: PDFDoc::getStartXRef(bool) (poppler/PDFDoc.cc:2003) ==3735668== by 0x4A04BB8: PDFDoc::setup(std::optional<GooString> const&, std::optional<GooString> const&, std::function<void ()> const&) (poppler/PDFDoc.cc:246) ==3735668== by 0x4A04AAB: PDFDoc::PDFDoc(std::unique_ptr<GooString, std::default_delete<GooString> >&&, std::optional<GooString> const&, std::optional<GooString> const&, void*, std::function<void ()> const&) (poppler/PDFDoc.cc:160) ==3735668== by 0x49F93EA: LocalPDFDocBuilder::buildPDFDoc(GooString const&, std::optional<GooString> const&, std::optional<GooString> const&, void*) (poppler/LocalPDFDocBuilder.cc:0) ==3735668== by 0x4A1FBB5: PDFDocFactory::createPDFDoc(GooString const&, std::optional<GooString> const&, std::optional<GooString> const&, void*) (poppler/PDFDocFactory.cc:62) ==3735668== Address 0x669cf54 is 0 bytes after a block of size 148 alloc'd ==3735668== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==3735668== by 0x4A35815: gmalloc (goo/gmem.h:44) ==3735668== by 0x4A35815: gmallocn (goo/gmem.h:121) ==3735668== by 0x4A35815: utf8ToUtf16(char const*, int*) (poppler/UTF.cc:367) ==3735668== by 0x4A358D4: utf8ToUtf16WithBom(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (poppler/UTF.cc:379) ==3735668== by 0x49F2C97: Lexer::getObj(int) (poppler/Lexer.cc:424) ==3735668== by 0x4A035C2: Parser::Parser(XRef*, Stream*, bool) (poppler/Parser.cc:50) ==3735668== by 0x49F888B: Linearization::Linearization(BaseStream*) (poppler/Linearization.cc:28) ==3735668== by 0x4A06D8D: getLinearization (poppler/PDFDoc.cc:648) ==3735668== by 0x4A06D8D: PDFDoc::isLinearized(bool) (poppler/PDFDoc.cc:700) ==3735668== by 0x4A0518D: PDFDoc::getStartXRef(bool) (poppler/PDFDoc.cc:2003) ==3735668== by 0x4A04BB8: PDFDoc::setup(std::optional<GooString> const&, std::optional<GooString> const&, std::function<void ()> const&) (poppler/PDFDoc.cc:246) ==3735668== by 0x4A04AAB: PDFDoc::PDFDoc(std::unique_ptr<GooString, std::default_delete<GooString> >&&, std::optional<GooString> const&, std::optional<GooString> const&, void*, std::function<void ()> const&) (poppler/PDFDoc.cc:160) ==3735668== by 0x49F93EA: LocalPDFDocBuilder::buildPDFDoc(GooString const&, std::optional<GooString> const&, std::optional<GooString> const&, void*) (poppler/LocalPDFDocBuilder.cc:0) ==3735668== by 0x4A1FBB5: PDFDocFactory::createPDFDoc(GooString const&, std::optional<GooString> const&, std::optional<GooString> const&, void*) (poppler/PDFDocFactory.cc:62) ``` Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=59840
-
- Jun 15, 2023
-
-
Sune Vuorela authored
This reverts commit 2dcbf583.
-
- Jun 14, 2023
-
-
Albert Astals Cid authored
-
Oliver Sander authored
It is not used.
-
- Jun 13, 2023
-
-
Albert Astals Cid authored
-
Sune Vuorela authored
-
- Jun 12, 2023
-
-
Sune Vuorela authored
fixes #215
-
- Jun 09, 2023
-
-
Sune Vuorela authored
Happened as a mismerge during !1394
-
Sune Vuorela authored
Resolves !1402. Thanks, Thomas
-
- Jun 06, 2023
-
-
Sune Vuorela authored
-
- Jun 05, 2023
-
-
Sune Vuorela authored
-
Albert Astals Cid authored
-
Sune Vuorela authored
This fixes a potential crash in setups where at least one cryptographic signature backend is compiled in, but none is functional.
-
- Jun 04, 2023
-
-
Sune Vuorela authored
Some non-scientific experiments: A single 8k pdf document with okular adding a simple typewriter annotation with content "aoeu" in approximately the same place grows without this patch to 894k. With this patch, it grows to 649k. For comparison, if one doesn't embed the widths content at all, the same process grew to 638k While this isn't ground breaking gains, it is still some improvement.
-
- May 30, 2023
-
-
Sune Vuorela authored
-
- May 27, 2023
-
-
Albert Astals Cid authored
-
Khaled Hosny authored
There is no BaseFont in Type 3 fonts, so we first try fontDescriptor’s FontName, but fontDescriptor is optional so we then try the Name key. Fixes #1396
-