Skip to content
Snippets Groups Projects

meson: properly set the partial_dependency(es)

Merged Emil Velikov requested to merge xexaxo/waffle:partial-deps into master

Our current loop creates a local dependency, only to discard it. Instead it should be overriding the proper dependency variables, via set_variable()

As-is we end-up linking against the libraries, where some are discarded by the linker, since meson uses `-Wl,--as-needed' by default.

With this fixed, issues like 2c335972 become apparent, instead of being masked out.

Fixes: b6d94483 ("meson: use include/compile_args dependencies") Signed-off-by: Emil Velikov emil.l.velikov@gmail.com

Merge request reports

Pipeline #998011 passed

Pipeline passed for 89e9ac64 on xexaxo:partial-deps

Merged by Emil VelikovEmil Velikov 1 year ago (Sep 29, 2023 3:26pm UTC)

Merge details

  • Changes merged into with 89e9ac64.
  • Deleted the source branch.

Pipeline #998013 passed

Pipeline passed for 89e9ac64 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading