Skip to content

framework/replay: fix replay with single trace, without specifying device

David Heidelberg requested to merge dh/piglit:fix_replay_without_device into main

Piglit crashes, when is run without device comparing single trace. It shouldn't be needed.

f.e.

PIGLIT_SOURCE_DIR="../" ./replayer.py compare trace /home/projects/collabora/traces-db/0ad/0ad-v2.trace 0

should be valid, but does crash with:

...
  File "/home/projects/collabora/piglit/replayer/../framework/replay/compare_replay.py", line 81, in _check_trace
    dir_in_results = path.join('trace', OPTIONS.device_name, trace_dir)
  File "/usr/lib/python3.10/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/usr/lib/python3.10/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

Signed-off-by: David Heidelberg david.heidelberg@collabora.com

Edited by David Heidelberg

Merge request reports