Skip to content
Snippets Groups Projects

Add tests for OES_texture_buffer

Closed Alejandro Piñeiro requested to merge apinheiro/piglit:apinheiro/oes-texture-buffer into main

This MR adds tests for the extension OES_texture_buffer. They are mostly ports from the ARB_texture_buffer_object and ARB_texture_buffer_range, updating the shaders and removing the stuff not supported on OpenGL ES.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added Tests label

  • Right now this MR also includes some changes on fbo-pbo-readpixels. Although they are not direct OES_texture_buffer tests, internally the extension is used to do asynchronously the copy. Those changes just expand the list of cases, specifically adding cases that needed special handling on v3d.

    Having said so, I'm not fully sure if they make sense to be included here. Perhaps we should just focus on the new tests.

    Assigning @jasuarez as reviewer, as he has been working on getting async copies working on v3d, even if focused on the ARB extensions (mesa!13409 (merged)).

  • requested review from @jasuarez

  • If VK-GL-CTS already has ES texture buffer formats tests, does piglit need one too?

    • Resolved by Alejandro Piñeiro

      Doesn't that applies to any spec now? Isn't interesting to keep expanding piglit anymore?

      To give some context: I wrote down those tests because when I started working on the implementation for those extensions on v3d it was far easier to debug and modify piglit tests. And as those are written, I thought that it would be interesting to submit them to piglit. Because if having tests on vk-gl-cts is a reason to not keep expanding piglit coverage, what is current piglit now? It is supposed to be on maintenance mode?

  • Alejandro Piñeiro resolved all threads

    resolved all threads

Please register or sign in to reply
Loading