Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P piglit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 69
    • Merge requests 69
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • piglit
  • Merge requests
  • !39

Add a new test for a structure uniform splitting bug with samplers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Graunke requested to merge kwg/piglit:struct-bug into master Apr 11, 2019
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 1

Michael Fiano discovered an i965 crash in Mesa 19.0 when a uniform structure contains samplers. We were splitting the structure into separate uniforms but botching the locations, leaving them set to 0, then reading the wrong uniform storage and seeing the VS's matrix.

This test was reduced from his (MIT-licensed) application's shaders.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: struct-bug