Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P piglit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • piglit
  • Merge requests
  • !124

Merged
Created Sep 04, 2019 by Neil Roberts@nrobertsDeveloper

Add tests for the precision qualifiers of return values of a function

  • Overview 2
  • Commits 2
  • Changes 2

In GLSL ES, all types can have a precision qualifier, including the return type of a function. According to this quote in the GLSL ES spec, the precision of the return type should match between multiple declarations of the same function:

Only a precision qualifier is allowed on the return type of a function. […] If a function name is declared twice with the same parameter types, then the return types and all qualifiers must also match, and it is the same function being declared.

This merge request adds a couple of tests to ensure that breaking these rules makes the shader fail to compile.

Mesa currently just ignores precision qualifiers on return types of functions. There is a merge request for Mesa to change this behaviour so that it stores the precision internally and also checks for the mismatches.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: return-precision