Skip to content

iris: bufmgr updates

Kenneth Graunke requested to merge kwg/mesa:iris-vma into master

Here's a small pile of iris buffer manager changes I wrote today. They:

  1. Fix locking bugs on non-LLC systems (doesn't exist in i965)
  2. Fix locking bugs with userptr (doesn't exist in i965)
  3. Delete all non-error-handling gotos (always thought they were ugly, now we've had an actual bug, so time to die)
  4. Spring cleaning galore
  5. Improves OglDrvRes performance by 22%, which had regressed when I dropped the bucketing allocators (thanks to @craftyguy for catching this)
  6. Restore the ability to require an aligned VMA address when allocating a BO (needed by some of @jljusten's work)
  7. Makes us defer returning VMA for reuse until BOs are idle. This isn't strictly necessary today, but some of @jljusten's work will require it, and I figure we may as well try it out now and see if we run into any downside.

I would appreciate review on this series. It's better to have more eyes on the foundations.

Merge request reports