Skip to content

panfrost/lcra: Fix constraint counting

Alyssa Rosenzweig requested to merge alyssa/mesa:lcra-hotfix into master

We need to iterate the whole row, we can't be clever and only look at one side, the symmetry doesn't work like that. See the original paper.

total instructions in shared programs: 69392 -> 69322 (-0.10%) instructions in affected programs: 9002 -> 8932 (-0.78%) helped: 82 HURT: 28 Instructions are helped.

total bundles in shared programs: 32225 -> 32155 (-0.22%) bundles in affected programs: 4286 -> 4216 (-1.63%) helped: 82 HURT: 28 Bundles are helped.

total quadwords in shared programs: 56102 -> 56102 (0.00%) quadwords in affected programs: 0 -> 0 helped: 0 HURT: 0

total registers in shared programs: 4552 -> 4572 (0.44%) registers in affected programs: 298 -> 318 (6.71%) helped: 18 HURT: 38 Registers are HURT.

total threads in shared programs: 3772 -> 3775 (0.08%) threads in affected programs: 84 -> 87 (3.57%) helped: 15 HURT: 14 Inconclusive result (value mean confidence interval includes 0).

total spills in shared programs: 0 -> 0 spills in affected programs: 0 -> 0 helped: 0 HURT: 0

total fills in shared programs: 0 -> 0 fills in affected programs: 0 -> 0 helped: 0 HURT: 0

Fixes: 66ad64d7 ("pan/midgard: Implement linearly-constrained register allocation") Signed-off-by: Alyssa Rosenzweig alyssa@collabora.com

Merge request reports