Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,049
    • Issues 3,049
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 993
    • Merge requests 993
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !929

WIP: nir: fix deref comparison where a cast deref gets larger.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dave Airlie requested to merge airlied/mesa:nir-deref-compare-upsize-casts into main May 22, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 2

We have cases from CL side where we have an array deref followed by a cast deref. but the array deref gets element[0], and the cast upsizes it to a uvec2. Now when we do the a contains b comparisons, we assume that subsequent casts get smaller or remain the same size but this isn't true in this case. Work out the sizes of the types and if the cast upscales, unset the bits.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nir-deref-compare-upsize-casts