Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,374
    • Issues 2,374
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 656
    • Merge Requests 656
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Mesa
  • mesamesa
  • Merge Requests
  • !8715

Open
Opened Jan 26, 2021 by Simon Ser@emersionContributor
  • Report abuse
Report abuse

gbm: fail early when modifier list only contains INVALID

  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

The current check only accomodates for a list with a single INVALID item. However the driver won't be able to pick any modifier if the list only contains INVALID. This includes the following cases:

  • The modifier list is empty (count == 0)
  • The modifier list contains more than a single item, but all items are INVALID

In these cases, also fail early.

Signed-off-by: Simon Ser contact@emersion.fr References: !7601 (comment 778845)

cc @rmader @pq @daniels

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: mesa/mesa!8715
Source branch: gbm-detect-mod-invalid