Skip to content

vtn: Handle ZeroExtend/SignExtend image operands

Connor Abbott requested to merge cwabbott0/mesa:review/vtn-image-extend-operand into master

These decorations allow you to override the signedness of image instructions (though this only really matters for reads AFAIK). This means that we have to override the type we get from the sampled image.

Apparently both Intel and AMD get the destination type from the descriptor rather than the instruction, but this appears to not be the case with Adreno, which is why this wasn't noticed until now. So this probably won't fix any preexisting bugs, but it's required to fix dEQP-VK.image.extend_operands_spirv1p4.* when exposing VK_KHR_spirv_1_4 on turnip.

Merge request reports