Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,884
    • Issues 2,884
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 921
    • Merge requests 921
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !7825

Open
Created Nov 28, 2020 by Erico Nunes@enunesDeveloper
  • Report abuse
Report abuse

lima: implement clip plane lowering

  • Overview 13
  • Commits 2
  • Pipelines 9
  • Changes 9

This is a followup to !7088 (merged). I had started an investigation about this using OpenGL ES 1 in comments !7088 (comment 650663) and below.

It is based on the vc4 clip plane lowering implementation, and follows the same method as the mali driver.

Mesa does have some built-in partial handling for clip planes in st_program, but to correctly handle enabling and disabling clip planes during runtime, clip plane lowering must be implemented in the backend too.

For the vertex shader in lima, the load_user_clip_plane intrinsic must be created before nir_lower_viewport_transform. Otherwise, it uses the transformed position which is not what is expected while calculating clip plane coordinates. This is what took me longer to figure out.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: lima-clip-planes