Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,884
    • Issues 2,884
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 906
    • Merge requests 906
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !7251

Merged
Created Oct 21, 2020 by Juan A. Suárez@jasuarezDeveloper

v3d/vc4: restore alpha-test lowering

  • Overview 3
  • Commits 5
  • Pipelines 9
  • Changes 12

!2213 (merged) included an alpha-test lowering for V3D/VC4, which was causing regressions (#1973 (closed)) and thus were reverted in !2399 (merged).

This MR reintroduces the commits reverted, as well as a fix for the problem that was causing those regressions.

Summing up, the problem was when using GL_NEVER as alpha test func; the lowering in this case never happens, and thus no fragment is discarded. The solution seems to rather initialize the alpha_func as GL_ALWAYS, and run the lowering if the function has changed (because GL_ALWAYS has the same effect as not running the alpha test).

/cc @kusma

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: review/v3d-revert-alphatest-lowering