Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,062
    • Issues 3,062
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 993
    • Merge requests 993
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !638

glsl: Set location on structure-split sampler uniform variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Graunke requested to merge kwg/mesa:struct-bug into master Apr 11, 2019
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

gl_nir_lower_samplers_as_deref splits structure uniform variables, creating new variables for individual fields. As part of that, it calculates a new location. It then never set this on the new variables.

Thanks to Michael Fiano for finding this bug. Fixes crashes on i965 with Piglit's new tests/spec/glsl-1.10/execution/sampler-struct-bug test, which was reduced from the failing case in Michael's app.

Fixes: f003859f nir: Make gl_nir_lower_samplers use gl_nir_lower_samplers_as_deref

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: struct-bug