Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,062
    • Issues 3,062
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 993
    • Merge requests 993
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !628

nir/xfb: do not use bare interface type

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Juan A. Suárez requested to merge jasuarez/mesa:review/unbare-xfb into master Apr 10, 2019
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 1

In commit 3b3653c4 we decided not to use bare types; hence do not use bare type when comparing with interface type to find out if the xfb variable is an array block.

This fixes dEQP-VK.transform_feedback.* tests.

Fixes: 3b3653c4 ("nir/spirv: don't use bare types, remove assert in split vars for testing") CC: Dave Airlie airlied@redhat.com CC: Jason Ekstrand jason@jlekstrand.net

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/unbare-xfb