Skip to content
Snippets Groups Projects

anv: Use the same re-order mode for streamout as for GS

Open Faith Ekstrand requested to merge gfxstrand/mesa:review/anv-xfb-reorder-mode into main

This makes the vertex order of TRISTRIP and TRISTRIP_ADJ primitves consistent between XFB output and GS input. Technically, the Vulkan spec allows us to XFB out in whatever order we want but being consistent with GS inputs is probably nicer to apps.

Fixes: 36ee2fd6 "anv: Implement the basic form of VK_EXT_transform_feedback"

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added ANV label

  • Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

  • Unfortunately, this doesn't seem to fix the problem.

    Before this patch, the xfb values were correct when a GS was NOT used and the xfb values were incorrect when a GS WAS used.

    Now, with the patch, the xfb values are incorrect in both cases (GS used/unused).

    It seems the patch only effects xfb vertex order when GS is unused. The patch has no effect when GS is used.

    And note that correct vs. incorrect is using Nvidia's driver as the reference (which passes the whck test in question).

    Thanks for looking into this. I'll be on vacation the next two weeks so no rush.

  • Jordan Justen changed target branch from master to main

    changed target branch from master to main

Please register or sign in to reply
Loading