Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,065
    • Issues 3,065
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 998
    • Merge requests 998
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !54

radv: Do a cache flush if needed before reading predicates.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bas Nieuwenhuizen requested to merge bnieuwenhuizen/mesa:conditional-rendering-flush-fix into master Dec 31, 2018
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

This caused random failures for two conditional rendering tests:

dEQP-VK.conditional_rendering.draw_clear.draw.update_with_rendering_discard
dEQP-VK.conditional_rendering.draw_clear.draw.update_with_rendering_no_discard

These wrote the predicate with the vertex shader, did a barrier and then started the conditional rendering. However the cache flushes for the barrier only happen on first draw, so after the predicate has been read.

Fixes: e45ba51e "radv: add support for VK_EXT_conditional_rendering"

Edited Dec 31, 2018 by Bas Nieuwenhuizen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: conditional-rendering-flush-fix