Skip to content

anv/allocator: Compare to start_offset in state_pool_free_no_vg

Faith Ekstrand requested to merge gfxstrand/mesa:review/issue-3100 into master

In d11e4738, we started using a start_offset to allow us to allocate pools where the base address isn't at the start of the pool. This is useful for binding table pools which want to be relative to surface state base address (more or less), among other things. However, we had a bug where, if you have a negative offset, everything returned to the pool would end up being returned to the "back" of the pool. This isn't what we want for binding tables in the softpin world. This was causing us to never actually re-use any binding table blocks. How this passed CTS, I have no idea.

Closes: #3100 (closed) Fixes: d11e4738 "anv/allocator: Add a start_offset to anv_state_pool"

Merge request reports