Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !5369

util: introduce os_dupfd_cloexec() helper, use it in place of F_DUPFD_CLOEXEC, and replace all remaining dup() with it

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Eric Engestrom requested to merge eric/mesa:os_dupfd_cloexec into master Jun 06, 2020
  • Overview 13
  • Commits 13
  • Pipelines 10
  • Changes 34

Adapted from wayland's wl_os_dupfd_cloexec().

The F_DUPFD_CLOEXEC -> os_dupfd_cloexec() are all squashed into a single commit because it shouldn't have any behaviour change, except that it might work now on platforms where it was broken because F_DUPFD_CLOEXEC is not supported but FD_CLOEXEC is.

The "replace all dup() with os_dupfd_cloexec()" commits are split per module for proper review.

I also needed to replace defined(WIN32) with DETECT_OS_WINDOWS because the meson-windows-vs2019 job was going down the non-windows path and I started putting non-windows stuff in that path, which broke the build. (I'm guessing the native windows build defines _WIN32 but not WIN32)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: os_dupfd_cloexec