Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,879
    • Issues 2,879
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 912
    • Merge requests 912
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge requests
  • !5171

Merged
Created May 22, 2020 by Jason Ekstrand@jekstrandOwner

nir: Some metadata improvements

  • Overview 4
  • Commits 6
  • Pipelines 16
  • Changes 59

This MR makes a few passes report metadata more correctly and attempts to make it easier with a new nir_metadata_all enum and some better documentation. It's not nearly as big of a rework as !950 so I'm hoping that maybe it'll actually land.

For core NIR, I've broken the cleanups into two patches. The first one should be entirely mechanical while the second one requires closer reading. Hopefully that makes review a bit easier.

FYI: I Do not intend to land the last patch in the MR. It exists simply to show that, on Intel, I now have everything for which we use NIR_PASS reporting metadata. I do not expect other drivers to fix all their passes before we land the patches to fix the pile of core NIR issues I found.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: review/nir-metadata-all