Skip to content

lima/ppir: more tex rework and optimization

Erico Nunes requested to merge enunes/mesa:lima-ppir-rework-tex into master

No regressions in deqp and piglit.

I'm aware patch "lima/ppir: improve handling for successors in other blocks" is a little hacky as explained in the commit message. I appreciate suggestions on how to solve that in a better way if there is one now. I plan on keep working on the scheduler after this so I think that's when we may be able to have a proper solution (and possibly put successors in other blocks to succ_list and not break anything).

instructions helped:   shaders/tesseract/441.shader_test MESA_SHADER_FRAGMENT: 219 -> 218 (-0.46%)
instructions helped:   shaders/tesseract/429.shader_test MESA_SHADER_FRAGMENT: 196 -> 195 (-0.51%)
instructions helped:   shaders/tesseract/417.shader_test MESA_SHADER_FRAGMENT: 173 -> 172 (-0.58%)
instructions helped:   shaders/tesseract/405.shader_test MESA_SHADER_FRAGMENT: 150 -> 149 (-0.67%)
instructions helped:   shaders/tesseract/393.shader_test MESA_SHADER_FRAGMENT: 127 -> 126 (-0.79%)
instructions helped:   shaders/tesseract/437.shader_test MESA_SHADER_FRAGMENT: 217 -> 215 (-0.92%)
instructions helped:   shaders/tesseract/381.shader_test MESA_SHADER_FRAGMENT: 104 -> 103 (-0.96%)
instructions helped:   shaders/tesseract/425.shader_test MESA_SHADER_FRAGMENT: 194 -> 192 (-1.03%)
instructions helped:   shaders/tesseract/413.shader_test MESA_SHADER_FRAGMENT: 171 -> 169 (-1.17%)
instructions helped:   shaders/tesseract/369.shader_test MESA_SHADER_FRAGMENT: 81 -> 80 (-1.23%)
instructions helped:   shaders/tesseract/488.shader_test MESA_SHADER_FRAGMENT: 150 -> 148 (-1.33%)
instructions helped:   shaders/tesseract/401.shader_test MESA_SHADER_FRAGMENT: 148 -> 146 (-1.35%)
instructions helped:   shaders/unity/40.shader_test MESA_SHADER_FRAGMENT: 204 -> 201 (-1.47%)
instructions helped:   shaders/tesseract/389.shader_test MESA_SHADER_FRAGMENT: 125 -> 123 (-1.60%)
instructions helped:   shaders/unity/39.shader_test MESA_SHADER_FRAGMENT: 231 -> 227 (-1.73%)
instructions helped:   shaders/tesseract/357.shader_test MESA_SHADER_FRAGMENT: 57 -> 56 (-1.75%)
instructions helped:   shaders/0ad/12.shader_test MESA_SHADER_FRAGMENT:  112 -> 110 (-1.79%) (spills: 1 -> 0; fills: 4 -> 0)
instructions helped:   shaders/unity/236-PBSApproximationSlices.shader_test MESA_SHADER_FRAGMENT: 54 -> 53 (-1.85%)
instructions helped:   shaders/tesseract/377.shader_test MESA_SHADER_FRAGMENT: 102 -> 100 (-1.96%)
instructions helped:   shaders/chromeos/24.shader_test MESA_SHADER_FRAGMENT: 48 -> 47 (-2.08%)
instructions helped:   shaders/tesseract/238.shader_test MESA_SHADER_FRAGMENT: 45 -> 44 (-2.22%)
instructions helped:   shaders/tesseract/241.shader_test MESA_SHADER_FRAGMENT: 45 -> 44 (-2.22%)
instructions helped:   shaders/tesseract/235.shader_test MESA_SHADER_FRAGMENT: 45 -> 44 (-2.22%)
instructions helped:   shaders/tesseract/232.shader_test MESA_SHADER_FRAGMENT: 45 -> 44 (-2.22%)
instructions helped:   shaders/unity/30-Tree.shader_test MESA_SHADER_FRAGMENT: 41 -> 40 (-2.44%)
instructions helped:   shaders/unity/38.shader_test MESA_SHADER_FRAGMENT: 244 -> 238 (-2.46%)
instructions helped:   shaders/tesseract/365.shader_test MESA_SHADER_FRAGMENT: 79 -> 77 (-2.53%)
instructions helped:   shaders/tesseract/223.shader_test MESA_SHADER_FRAGMENT: 37 -> 36 (-2.70%)
instructions helped:   shaders/tesseract/229.shader_test MESA_SHADER_FRAGMENT: 37 -> 36 (-2.70%)
instructions helped:   shaders/tesseract/220.shader_test MESA_SHADER_FRAGMENT: 37 -> 36 (-2.70%)
instructions helped:   shaders/tesseract/226.shader_test MESA_SHADER_FRAGMENT: 37 -> 36 (-2.70%)
instructions helped:   shaders/tesseract/96.shader_test MESA_SHADER_FRAGMENT: 34 -> 33 (-2.94%)
instructions helped:   shaders/unity/27-Tree.shader_test MESA_SHADER_FRAGMENT: 30 -> 29 (-3.33%)
instructions helped:   shaders/humus-portals/1.shader_test MESA_SHADER_FRAGMENT: 30 -> 29 (-3.33%)
instructions helped:   shaders/tesseract/214.shader_test MESA_SHADER_FRAGMENT: 29 -> 28 (-3.45%)
instructions helped:   shaders/tesseract/211.shader_test MESA_SHADER_FRAGMENT: 29 -> 28 (-3.45%)
instructions helped:   shaders/tesseract/208.shader_test MESA_SHADER_FRAGMENT: 29 -> 28 (-3.45%)
instructions helped:   shaders/tesseract/217.shader_test MESA_SHADER_FRAGMENT: 29 -> 28 (-3.45%)
instructions helped:   shaders/warzone2100/1.shader_test MESA_SHADER_FRAGMENT: 57 -> 55 (-3.51%)
instructions helped:   shaders/tesseract/353.shader_test MESA_SHADER_FRAGMENT: 57 -> 55 (-3.51%)
instructions helped:   shaders/unity/41.shader_test MESA_SHADER_FRAGMENT: 140 -> 135 (-3.57%)
instructions helped:   shaders/unity/57-DeferredDirectional.shader_test MESA_SHADER_FRAGMENT: 110 -> 106 (-3.64%)
instructions helped:   shaders/unity/59-DeferredPoint.shader_test MESA_SHADER_FRAGMENT: 103 -> 99 (-3.88%)
instructions helped:   shaders/glmark/1-24.shader_test MESA_SHADER_FRAGMENT: 51 -> 49 (-3.92%)
instructions helped:   shaders/unity/60-DeferredSpot.shader_test MESA_SHADER_FRAGMENT: 115 -> 110 (-4.35%)
instructions helped:   shaders/0ad/9.shader_test MESA_SHADER_FRAGMENT:   22 -> 21 (-4.55%)
instructions helped:   shaders/unity/41-GrassBillboard.shader_test MESA_SHADER_FRAGMENT: 22 -> 21 (-4.55%)
instructions helped:   shaders/unity/50.shader_test MESA_SHADER_FRAGMENT: 325 -> 310 (-4.62%)
instructions helped:   shaders/glmark/1-10.shader_test MESA_SHADER_FRAGMENT: 21 -> 20 (-4.76%)
instructions helped:   shaders/tesseract/205.shader_test MESA_SHADER_FRAGMENT: 21 -> 20 (-4.76%)
instructions helped:   shaders/tesseract/196.shader_test MESA_SHADER_FRAGMENT: 21 -> 20 (-4.76%)
instructions helped:   shaders/tesseract/199.shader_test MESA_SHADER_FRAGMENT: 21 -> 20 (-4.76%)
instructions helped:   shaders/tesseract/202.shader_test MESA_SHADER_FRAGMENT: 21 -> 20 (-4.76%)
instructions helped:   shaders/unity/99-Water.shader_test MESA_SHADER_FRAGMENT: 101 -> 96 (-4.95%)
instructions helped:   shaders/unity/59.shader_test MESA_SHADER_FRAGMENT: 19 -> 18 (-5.26%)
instructions helped:   shaders/unity/139-ScreenPos.shader_test MESA_SHADER_FRAGMENT: 19 -> 18 (-5.26%)
instructions helped:   shaders/tesseract/112.shader_test MESA_SHADER_FRAGMENT: 19 -> 18 (-5.26%)
instructions helped:   shaders/unity/131-ColoredSpecular.shader_test MESA_SHADER_FRAGMENT: 33 -> 31 (-6.06%)
instructions helped:   shaders/unity/151-Slices.shader_test MESA_SHADER_FRAGMENT: 16 -> 15 (-6.25%)
instructions helped:   shaders/yofrankie/39.shader_test MESA_SHADER_FRAGMENT: 16 -> 15 (-6.25%)
instructions helped:   shaders/yofrankie/21.shader_test MESA_SHADER_FRAGMENT: 16 -> 15 (-6.25%)
instructions helped:   shaders/unity/64-DeferredPointShadows.shader_test MESA_SHADER_FRAGMENT: 125 -> 117 (-6.40%)
instructions helped:   shaders/unity/51.shader_test MESA_SHADER_FRAGMENT: 136 -> 127 (-6.62%)
instructions helped:   shaders/glmark/4-2.shader_test MESA_SHADER_FRAGMENT: 15 -> 14 (-6.67%)
instructions helped:   shaders/glmark/1-11.shader_test MESA_SHADER_FRAGMENT: 30 -> 28 (-6.67%)
instructions helped:   shaders/unity/121-WorldNormalReflBump.shader_test MESA_SHADER_FRAGMENT: 41 -> 38 (-7.32%)
instructions helped:   shaders/tesseract/193.shader_test MESA_SHADER_FRAGMENT: 13 -> 12 (-7.69%)
instructions helped:   shaders/tesseract/184.shader_test MESA_SHADER_FRAGMENT: 13 -> 12 (-7.69%)
instructions helped:   shaders/tesseract/187.shader_test MESA_SHADER_FRAGMENT: 13 -> 12 (-7.69%)
instructions helped:   shaders/tesseract/190.shader_test MESA_SHADER_FRAGMENT: 13 -> 12 (-7.69%)
instructions helped:   shaders/unity/159-RimLightBump.shader_test MESA_SHADER_FRAGMENT: 23 -> 21 (-8.70%)
instructions helped:   shaders/glmark/7-3.shader_test MESA_SHADER_FRAGMENT: 11 -> 10 (-9.09%)
instructions helped:   shaders/warzone2100/4.shader_test MESA_SHADER_FRAGMENT: 11 -> 10 (-9.09%)
instructions helped:   shaders/tesseract/81.shader_test MESA_SHADER_FRAGMENT: 30 -> 27 (-10.00%)
instructions helped:   shaders/tesseract/75.shader_test MESA_SHADER_FRAGMENT: 30 -> 27 (-10.00%)
instructions helped:   shaders/tesseract/78.shader_test MESA_SHADER_FRAGMENT: 38 -> 34 (-10.53%)
instructions helped:   shaders/tesseract/84.shader_test MESA_SHADER_FRAGMENT: 38 -> 34 (-10.53%)
instructions helped:   shaders/glmark/4-3.shader_test MESA_SHADER_FRAGMENT: 18 -> 16 (-11.11%)
instructions helped:   shaders/tesseract/178.shader_test MESA_SHADER_FRAGMENT: 9 -> 8 (-11.11%)
instructions helped:   shaders/tesseract/175.shader_test MESA_SHADER_FRAGMENT: 9 -> 8 (-11.11%)
instructions helped:   shaders/tesseract/172.shader_test MESA_SHADER_FRAGMENT: 9 -> 8 (-11.11%)
instructions helped:   shaders/tesseract/181.shader_test MESA_SHADER_FRAGMENT: 9 -> 8 (-11.11%)
instructions helped:   shaders/tesseract/121.shader_test MESA_SHADER_FRAGMENT: 15 -> 13 (-13.33%)
instructions helped:   shaders/tesseract/133.shader_test MESA_SHADER_FRAGMENT: 7 -> 6 (-14.29%)
instructions helped:   shaders/tesseract/72.shader_test MESA_SHADER_FRAGMENT: 7 -> 6 (-14.29%)
instructions helped:   shaders/glmark/22-2.shader_test MESA_SHADER_FRAGMENT: 54 -> 45 (-16.67%)
instructions helped:   shaders/glmark/25-2.shader_test MESA_SHADER_FRAGMENT: 54 -> 45 (-16.67%)
instructions helped:   shaders/glmark/1-12.shader_test MESA_SHADER_FRAGMENT: 18 -> 15 (-16.67%)
instructions helped:   shaders/unity/15.shader_test MESA_SHADER_FRAGMENT: 6 -> 5 (-16.67%)
instructions helped:   shaders/warsow/85.shader_test MESA_SHADER_FRAGMENT: 89 -> 74 (-16.85%)
instructions helped:   shaders/glmark/13-2.shader_test MESA_SHADER_FRAGMENT: 28 -> 23 (-17.86%)
instructions helped:   shaders/glmark/16-2.shader_test MESA_SHADER_FRAGMENT: 28 -> 23 (-17.86%)
instructions helped:   shaders/unity/37-Terrain.shader_test MESA_SHADER_FRAGMENT: 28 -> 23 (-17.86%)
instructions helped:   shaders/tesseract/160.shader_test MESA_SHADER_FRAGMENT: 5 -> 4 (-20.00%)
instructions helped:   shaders/tesseract/169.shader_test MESA_SHADER_FRAGMENT: 5 -> 4 (-20.00%)
instructions helped:   shaders/tesseract/163.shader_test MESA_SHADER_FRAGMENT: 5 -> 4 (-20.00%)
instructions helped:   shaders/tesseract/166.shader_test MESA_SHADER_FRAGMENT: 5 -> 4 (-20.00%)
instructions helped:   shaders/supertuxkart/1.shader_test MESA_SHADER_FRAGMENT: 48 -> 38 (-20.83%)
instructions helped:   shaders/glmark/7.shader_test MESA_SHADER_FRAGMENT: 48 -> 37 (-22.92%)
instructions helped:   shaders/glmark/16.shader_test MESA_SHADER_FRAGMENT: 48 -> 37 (-22.92%)
instructions helped:   shaders/chromeos/36.shader_test MESA_SHADER_FRAGMENT: 4 -> 3 (-25.00%)
instructions helped:   shaders/chromeos/18.shader_test MESA_SHADER_FRAGMENT: 2 -> 1 (-50.00%)
instructions helped:   shaders/chromeos/39.shader_test MESA_SHADER_FRAGMENT: 2 -> 1 (-50.00%)
instructions helped:   shaders/glmark/19-2.shader_test MESA_SHADER_FRAGMENT: 2 -> 1 (-50.00%)

spills helped:   shaders/0ad/12.shader_test MESA_SHADER_FRAGMENT:  1 -> 0

fills helped:   shaders/0ad/12.shader_test MESA_SHADER_FRAGMENT:  4 -> 0

total instructions in shared programs: 18690 -> 18427 (-1.41%)
instructions in affected programs: 6253 -> 5990 (-4.21%)
helped: 104
HURT: 0
helped stats (abs) min: 1 max: 15 x̄: 2.53 x̃: 1
helped stats (rel) min: 0.46% max: 50.00% x̄: 8.40% x̃: 4.76%
95% mean confidence interval for instructions value: -3.10 -1.96
95% mean confidence interval for instructions %-change: -10.25% -6.56%
Instructions are helped.

total loops in shared programs: 3 -> 3 (0.00%)
loops in affected programs: 0 -> 0
helped: 0
HURT: 0

total spills in shared programs: 171 -> 170 (-0.58%)
spills in affected programs: 1 -> 0
helped: 1
HURT: 0

total fills in shared programs: 679 -> 675 (-0.59%)
fills in affected programs: 4 -> 0
helped: 1
HURT: 0

LOST:   0
GAINED: 0

Merge request reports