Skip to content

glsl/list: Fix undefined behaviour of foreach_in_list* macros

Danylo Piliaiev requested to merge GL/mesa:fix/ubsan-foreach-macro-warnings into master

It produced a lot of errors with ubsan preventing us from expanding the ubsan coverage on CIs.

C++ spec has such clause:

If the prvalue of type "pointer to cv1 B" points to a B that is actually a subobject of an object of type D, the resulting pointer points to the enclosing object of type D. Otherwise, the result of the cast is undefined.

Ubsan error example:

 ../src/compiler/glsl/builtin_functions.cpp:4945:4: runtime error: downcast of address 0x559b926abb50 which does not point to an object of type 'ir_instruction'
 0x559b926abb50: note: object has invalid vptr
  9b 55 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  58 ba 6a 92 9b 55 00 00  01 00 00 00
               ^~~~~~~~~~~~~~~~~~~~~~~
               invalid vptr
     #0 0x559b914dbe1a in call ../src/compiler/glsl/builtin_functions.cpp:4945

I don't like the updated macros, on the other hand I don't see the other way around.

Edited by Danylo Piliaiev

Merge request reports