Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3419

panfrost: Actually clean up signaled fences

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Icecream95 requested to merge icecream95/mesa:reader-clean into master Jan 15, 2020
  • Overview 18
  • Commits 1
  • Pipelines 10
  • Changes 1

Previously, the fence readers array was only cleared when there are no unsignaled fences, which almost never happens in some situations.

That resulted in the array having thousands of NULL pointers, but only a handful of active readers.

With this patch, all the unsignaled readers are moved to the front of the array, effectively building a new array only containing the active readers in-place. This results in the readers array usually only having a couple of elements.

Reallocation errors are not handled, because it is impossible for the array to grow -- we aren't getting new readers out of /dev/null.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: reader-clean