Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3334

radeonsi: fix leaks in si_compute_blit functions

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Pierre-Eric Pelloux-Prayer requested to merge pepp/mesa:radeonsi_fix_compute_memleak into master Jan 09, 2020
  • Overview 1
  • Commits 6
  • Pipelines 8
  • Changes 1

si_compute_copy_image, si_compute_clear_render_target, si_compute_expand_fmask and si_retile_dcc use the same pattern:

  • save the current image view(s)
  • perform some compute work
  • restore image view(s) but forgot to release the saved image view(s).

The last commit should fix #2330 (closed).

(marking as WIP until my tests are finished)

Edited Jan 09, 2020 by Pierre-Eric Pelloux-Prayer
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: radeonsi_fix_compute_memleak