Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3272

i965: Create internal front buffer if dri doesn't supply one

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Danylo Piliaiev requested to merge GL/mesa:fix/create-internal-front-buffer-if-no-external into main Jan 03, 2020
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 1

On some platforms e.g. gbm the concept of front buffer does not really exist, in such case dri_screen->image.loader->getBuffers would return us only __DRI_IMAGE_BUFFER_BACK when we request both.

Fix this by creating internal front buffer if we requested front buffer but didn't get one. Gallium has on demand front buffer creating so it doesn't have such issue.

Current implementation handles:

  • Resizes
  • Multisampling

Closes: #1641 Closes: #1731

In the CI several tests start passing and several tests start failing instead of crashing https://mesa-ci.01.org/global_logic/builds/236/group/63a9f0ea7bb98050796b649e85481845

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/create-internal-front-buffer-if-no-external