Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3.2k
    • Issues 3.2k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1k
    • Merge requests 1k
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • MesaMesa
  • mesamesa
  • Merge requests
  • !3100

freedreno/a6xx: fix OUT_REG() vs growable cmdstream

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Rob Clark requested to merge robclark/mesa:wip/struct-packing-fix into master Dec 14, 2019
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

BEGIN_RING() could decide we can't fit the next packet in the current cmdstream segment, and grow a new segment. So we need to grab ring->cur after BEGIN_RING(), otherwise we are writing cmdstream past the end of the previous segment.

Fixes: bdd98b89 ("freedreno: New struct packing macros") Signed-off-by: Rob Clark robdclark@chromium.org

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/struct-packing-fix