Skip to content

panfrost: fix texture.border_clamp regression for valhall

Eric Smith requested to merge ericsmith/mesa:valhall-border-color-swizzle into main 
panfrost: fix texture.border_clamp regression for valhall

We have to swizzle the border color in order to offset the
automatic swizzling introduced to compensate for limited
component order support in AFBC/AFRC. However, the border color
format is only available if the `TEXTURE_BORDER_COLOR_QUIRK` is
enabled, so set that for v10 (it was already set for v7).

While testing, we uncovered another issue: valhall introduces a
swizzle for depth+stencil formats that isn't present for bifrost, and
also isn't needed (or wanted) for the border color. So ignore the
border color swizzle for depth+stencil on valhall. (On bifrost the
swizzle is a no-op already).

Fixes: 87aad0a5e4f ("panfrost: encode component order as an inverted swizzle (v10)")

Merge request reports