Skip to content

v3dv: really fix CLE MMU errors on 7.1HW Rpi5

José María Casanova Crespo requested to merge chema/mesa:fix-mmu-cle-on-rpi5 into main

What does this MR do and why?

v3dv/v3dv: really fix CLE MMU errors on 7.1HW Rpi5

Macro values that define values for different HW generations should
use the V3DV_X helper instead of being defined under a V3D_VERSION #if
condition.

Without this change, the original V3D_CLE_READHAEAD and
V3D_CLE_BUFFER_MIN_SIZE definitions used were only working for 4.2 HW.
For the 7.1 HW (RPi5) the 4.2 definitions were applied.

The CLE MMU errors were hidden as they were reported at dmesg as
"MMU error from client PTB (1) at 0x1884200, pte invalid" instead of
client CLE. So fixes all v3dv dmesg warnings for PTB MMU errors on RPi5.

With this change we really don't need different functions per HW generation,
so we rename back files v3dvx_cl.c to v3dv_cl.c and v3dx_cl.c to v3dx_cl.c.
As before, we can use only the packets definitions for 4.2 HW as they use
the same opcode as 7.1 HW.

It fixes also an indentation error introduced with 26c8a5cd721 on v3dv_cl.c.

Merge request reports