Skip to content

venus: drop internal memory pools

Yiwei Zhang requested to merge zzyiwei/mesa:vn-drop-mem-suballoc into main

What does this MR do and why?

venus: drop internal memory pools

This exists due to historical limitations which have long gone obsolete.
This persists longer due to hostorical perf issues that have recently
gone obsolete on the platforms shipping Venus. Meanwhile, clients like
skiavk and ANGLE nowadays do a better job managing suballocations. The
tiny perf win from having this giant internal pool has been beaten by
the memory waste, longer one-shot jank due to largier alloc, allocations
no need to be mapped but only because host-visible is advertised across
mem types and varies workarounds and markups needed to make alignment
work and make VVL happy. Dropping it also reduces the maintenance cost.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>

Closes: #9351 (closed)

Besides above, this MR also:

  • fixes the missing sparse binding fixups
  • unblocks venus adoptions of VK_MESA_image_alignment_control for more memory savings

Perf wise:

  • no regressions in gfxbench scores via ANGLE-on-Venus
  • no additional janks for a few key titles via ANGLE-on-Venus even on very lower end devices
  • no additional janks with skiavk on venus on Android

/cc @justonli @ryanneph

Edited by Yiwei Zhang

Merge request reports