Skip to content

freedreno/ir3: Fix ldg/stg offset

Rob Clark requested to merge robclark/mesa:ir3/ldg-stg-offset into main

What does this MR do and why?

freedreno/ir3: Fix ldg/stg offset

Basically a revert (but not a clean one) of commit 60686d4146cd
("ir3/a6xx: fix ldg/stg of ulong2 and ulong4 data").  The offset
is a byte offset, not a dword offset.

Backport note: Prior to commit 513fa1873cf5 ("ir3/a7xx: Fix
load_global_ir3 with immediate offset") you could instead just revert
the original commit.

Fixes: 60686d4146cd ir3/a6xx: ("fix ldg/stg of ulong2 and ulong4 data")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11169
Signed-off-by: Rob Clark <robdclark@chromium.org>

@lumag I double confirmed with computerator that we indeed want a byte offset instead of a dword offset.. so I guess the root issue you were having (was it clover or rusticl?) was that you were getting dword offsets in the first place?

@cwabbott0 not tested on a7xx, but re: 513fa187, I wonder if that was just partially bodging over the bug caused by 60686d41, or if there is actually something different here btwn a6xx and a7xx (and if there is something different, why is it asymmetrical to stg)?

Merge request reports