Skip to content

ir3: always run optimize when creating shader variants

Mike Blumenkrantz requested to merge zmike/mesa:ir3-opt into main

This has some weird results:

Totals:
Instrs: 40912883 -> 40912893 (+0.00%)
CodeSize: 82998994 -> 82998990 (-0.00%)
NOPs: 8402185 -> 8402197 (+0.00%)
(ss): 1122875 -> 1122873 (-0.00%)
(ss)-stall: 3496388 -> 3496376 (-0.00%)
Cat0: 8993780 -> 8993792 (+0.00%)
Cat2: 15081662 -> 15081660 (-0.00%)

Totals from 2 (0.00% of 126999) affected shaders:
Instrs: 40 -> 50 (+25.00%)
CodeSize: 68 -> 64 (-5.88%)
NOPs: 18 -> 30 (+66.67%)
(ss): 6 -> 4 (-33.33%)
(ss)-stall: 12 -> 0 (-inf%)
Cat0: 24 -> 36 (+50.00%)
Cat2: 6 -> 4 (-33.33%)

In one of the pipelines I examined (I can send on demand) which has increased instruction counts, it looks like a few extra instructions get added in nir_lower_vars_to_ssa and then this never gets reduced again. Probably some missing optimization handling somewhere.

Merge request reports