Skip to content

tu/fdl: avoid array layer alignment for explicit layout

Yiwei Zhang requested to merge zzyiwei/mesa:tu-fix-explicit-layout-alignment into main

What does this MR do and why?

tu/fdl: avoid array layer alignment for explicit layout

With explicit layout, array pitch of a multi-layer image must also be
explicit. This is per VK_EXT_image_drm_format_modifier spec.

For gl side, explicit layout is only used in fill_ubwc_buffer_sizes
and page alignment is already there with UBWC. Added an assert for that.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>

Test: Android 13 CtsMediaDecoderTestCases passing 100% with skiavk on venus on turnip. Previously below are failing:

android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewLargerHeightDecodeAccuracy[3(c2.android.avc.decoder_h264_82x144)]
android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewLargerHeightDecodeAccuracy[7(c2.android.vp9.decoder_vp9_82x144)]
android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewLargerWidthDecodeAccuracy[3(c2.android.avc.decoder_h264_82x144)]
android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewLargerWidthDecodeAccuracy[7(c2.android.vp9.decoder_vp9_82x144)]
android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewVideoDecodeAccuracy[3(c2.android.avc.decoder_h264_82x144)]
android.media.decoder.cts.DecodeAccuracyTest#testSurfaceViewVideoDecodeAccuracy[7(c2.android.vp9.decoder_vp9_82x144)]

/cc @robclark

Edited by Yiwei Zhang

Merge request reports