Skip to content

nvk: remove useless MME scratch 26 usage

Arthur Huillet requested to merge ahuillet/mesa:main into main 
 nvk: remove useless MME scratch 26 usage
    
    The blob uses MME shadow scratch 26 to indicate whether or not it is running in
    a simulated environment (not real hardware).  If true, the SET_FALCON04
    firmware method used to modify PRI registers isn't used.
    
    As Nouveau only runs on real hardware, this is useless and can be removed.
    
    Tested by running dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_bvec2_fragment,
    which exposes the original issue with a ~50% failure rate on RTX3080
    (when disabling the register write altogether). With this change, the
    success rate remains at 100%.
    
    Signed-off-by: Arthur Huillet <ahuillet@nvidia.com>
Edited by Arthur Huillet

Merge request reports