Skip to content

anv, iris: add missing CS_STALL bit for GPGPU texture invalidation

Paulo Zanoni requested to merge pzanoni/mesa:tex-inval-wants-cs-stall into main

I came up with this while reading BSpec in order to try to understand caches so I could review another patch. I know of no particular workload that gets affected nor would benefit from it.

I ran it through CI and the results were fine (run 103 from me).

anv, iris: add missing CS_STALL bit for GPGPU texture invalidation

The BSpec page "Flush Types" (46213) says the following about the Tex
Invalidate bit:

  "Requires stall bit ([20] of DW) set for all GPGPU Workloads."

For newer platforms, this is documented in the description of the
texture invalidation bit in the PIPE_CONTROL page (56551):

  "CS Stall bit in PIPE_CONTROL command must be always set for GPGPU
   workloads when Texture Cache Invalidation Enable bit is set"

Iris had it only for GFX_VER 9 and 11, while Anv had it missing for
everything.
Edited by Paulo Zanoni

Merge request reports