Skip to content

nir_to_spirv: Allow LOD for external images

Gert Wollny requested to merge gerddie/mesa:ntv-quell-VUID-VkShaderModuleCreateInfo-pCode-08737-OpQueryImageSize into main

External images translate to 2D images in ntv, so we will have to emit OpImageQuerySizeLod instead of OpImageQuerySize (thanks Faith for pointing that out). This quells

  VUID-VkShaderModuleCreateInfo-pCode-08737

  Image must have either 'MS'=1 or 'Sampled'=0 or 'Sampled'=2
     %32 = OpImageQuerySize %v2int %31

triggred by piglit

  • spec@oes_egl_image_external_essl3@oes_egl_image_external_essl3

on Zink.

Fixes: 3f783a3c zink: omit Lod image operand in ntv when not using an image texture dim

Edited by Gert Wollny

Merge request reports