Skip to content

Revert "pan/mdg: Use .u32 for flat shading"

Alexandre Marquet requested to merge alexmrqt/mesa:t604-flatshading into main

In #10558 (closed), I reported that graphical artifacts when running glxgears on T604. As it turned out, this was not related to the main issue of #10558 (closed), as resolved in !27515 (merged). See also #10632 (closed).

glxgears.png

I was able to track down the issue to commit 17589be7. For some reason, T604 does not seem to be happy with using u32 for flat shading (I wonder if this issues affects other midgard GPUs). Note that similar code were initially committed for Bifrost (a5ec1e7f), in order to improve OpenGL conformance.

After trying the proposed reversion for a week on my device, I did not encounter any side effects.

Edited by Alexandre Marquet

Merge request reports