Skip to content

radv: sink and move alu

Georg Lehmann requested to merge DadSchoorse/mesa:radv-sink-move-alu into main

We didn't do this before because it hurt ILP on gfx10+, but since aco has a post-RA latency scheduler the stats are positive. Looking at some of the regressions, it seems like they could be further improved by changing the RA strategy (iirc ishi talked about round-robin in the past) to create more scheduling opportunities post-RA.

Foz-DB Navi31:
Totals:
MaxWaves: 2408188 -> 2412132 (+0.16%); split: +0.26%, -0.09%
Instrs: 42923924 -> 43106177 (+0.42%); split: -0.13%, +0.55%
CodeSize: 223708896 -> 224379692 (+0.30%); split: -0.14%, +0.44%
VGPRs: 3087784 -> 3065800 (-0.71%); split: -0.93%, +0.22%
SpillSGPRs: 8001 -> 6963 (-12.97%); split: -13.86%, +0.89%
SpillVGPRs: 1359 -> 1068 (-21.41%)
Scratch: 7006720 -> 6977792 (-0.41%)
Latency: 288559806 -> 288512895 (-0.02%); split: -0.72%, +0.70%
InvThroughput: 47374393 -> 47103318 (-0.57%); split: -0.95%, +0.38%
VClause: 828544 -> 832054 (+0.42%); split: -0.44%, +0.87%
SClause: 1337819 -> 1345242 (+0.55%); split: -0.83%, +1.38%
Copies: 2799637 -> 2798188 (-0.05%); split: -1.24%, +1.19%
Branches: 824324 -> 825144 (+0.10%); split: -0.03%, +0.13%
PreSGPRs: 2441882 -> 2438716 (-0.13%); split: -0.65%, +0.52%
PreVGPRs: 2268227 -> 2240298 (-1.23%); split: -1.36%, +0.13%
VALU: 24138102 -> 24134183 (-0.02%); split: -0.11%, +0.09%
SALU: 4121015 -> 4132378 (+0.28%); split: -0.38%, +0.65%
VMEM: 1502129 -> 1501607 (-0.03%)
VOPD: 8805 -> 8869 (+0.73%); split: +3.26%, -2.53%

Totals from 73409 (92.64% of 79242) affected shaders:
MaxWaves: 2222752 -> 2226696 (+0.18%); split: +0.28%, -0.10%
Instrs: 42603971 -> 42786224 (+0.43%); split: -0.13%, +0.56%
CodeSize: 222017904 -> 222688700 (+0.30%); split: -0.14%, +0.44%
VGPRs: 2997136 -> 2975152 (-0.73%); split: -0.96%, +0.22%
SpillSGPRs: 8001 -> 6963 (-12.97%); split: -13.86%, +0.89%
SpillVGPRs: 1359 -> 1068 (-21.41%)
Scratch: 7006720 -> 6977792 (-0.41%)
Latency: 286190058 -> 286143147 (-0.02%); split: -0.72%, +0.71%
InvThroughput: 46964539 -> 46693464 (-0.58%); split: -0.96%, +0.38%
VClause: 819727 -> 823237 (+0.43%); split: -0.45%, +0.88%
SClause: 1324211 -> 1331634 (+0.56%); split: -0.83%, +1.40%
Copies: 2777880 -> 2776431 (-0.05%); split: -1.25%, +1.20%
Branches: 819632 -> 820452 (+0.10%); split: -0.03%, +0.13%
PreSGPRs: 2373079 -> 2369913 (-0.13%); split: -0.67%, +0.53%
PreVGPRs: 2225845 -> 2197916 (-1.25%); split: -1.39%, +0.13%
VALU: 23994302 -> 23990383 (-0.02%); split: -0.11%, +0.09%
SALU: 4087187 -> 4098550 (+0.28%); split: -0.38%, +0.66%
VMEM: 1487147 -> 1486625 (-0.04%)
VOPD: 8651 -> 8715 (+0.74%); split: +3.32%, -2.58%

 PERCENTAGE DELTAS                   Shaders  MaxWaves   Instrs   CodeSize   VGPRs   SpillSGPRs SpillVGPRs  Scratch   Latency  InvThroughput  VClause   SClause    Copies   Branches  PreSGPRs  PreVGPRs    VALU      SALU      VMEM      VOPD   
 assassins_creed_valhalla            830       +1.46%    +0.35%    +0.31%    -2.68%       .          .         .       +0.20%      -0.24%      +0.85%    +0.82%    +0.08%    -0.03%    -0.26%    -1.62%    -0.03%    +0.12%      .       +4.85%  
 control                             4234      +0.06%    +0.40%    +0.34%    -0.07%       .          .         .       +0.53%      +0.24%      -0.11%    +0.21%    -0.98%    +0.01%    -0.00%    -0.37%    -0.04%    -0.39%      .         .     
 cyberpunk_2077                      2090      -0.12%    +0.37%    +0.30%    -0.26%    -2.16%     -26.18%   -37.95%    +0.84%      +0.89%      +0.94%    +1.92%    +0.02%    +0.26%    -0.40%    -0.74%    -0.06%    +0.47%    -0.23%    +1.88%  
 dead_space                          400         .       +0.41%    +0.42%    +0.06%    +2.06%        .         .       +0.06%      +0.10%      +0.33%    -0.58%    +0.22%      .       +0.06%    -0.82%    -0.06%    +0.61%      .         .     
 deathloop                           1130      +0.31%    +0.58%    +0.45%    -0.27%    -11.09%       .         .       -2.05%      -2.10%      +0.90%    -1.02%    +0.46%    -0.02%    +0.00%    -1.54%    -0.05%    +0.07%      .       -1.83%  
 detroit_become_human                995       +2.72%    +0.45%    +0.37%    -5.53%       .          .         .       +0.59%      -4.65%     +13.58%    +2.16%    +0.12%      .       -0.01%    -8.15%    +0.10%    -0.33%      .         .     
 deus_ex_md                          8063      +0.01%    +0.07%    +0.05%    -0.14%       .          .         .       -0.69%      +0.01%      +0.05%    -0.13%    +0.04%      .       +0.01%    -0.21%    +0.00%    +0.09%      .       -2.90%  
 doom_eternal                        447       +0.76%    +1.17%    +0.99%    -3.09%       .          .         .       +1.15%      -5.16%      +0.69%    -0.07%    +0.25%    +0.03%    -0.41%    -2.28%    -0.04%    +1.85%      .      +28.00%  
 dota2                               3840      +0.11%    +0.57%    +0.45%    -0.12%       .          .         .       +0.09%      -0.03%      -0.10%    +0.13%    +0.21%      .       +0.50%    -1.38%    +0.01%    +0.31%      .         .     
 dow3                                280         .       +0.27%    +0.31%    -0.43%       .          .         .       +0.83%      +0.88%      -0.36%    +0.12%    -1.99%      .       +0.22%    -0.85%    -0.30%    +0.03%      .      -13.85%  
 dredge                              2517        .       +0.78%    +0.50%    -0.04%       .          .         .       -0.85%      -0.03%      +0.37%    +0.43%    +1.84%      .       +0.91%    -1.55%    +0.22%    -0.01%      .         .     
 elden_ring                          3733      +0.03%    +0.36%    +0.27%    -0.22%    -10.53%       .         .       -0.23%      -0.26%      +0.09%    +0.75%    -0.01%    -0.00%    -2.29%    -0.24%    -0.02%    +0.28%      .       +0.90%  
 f1_23                               4006      +0.09%    +0.89%    +0.68%    -5.00%    -25.00%       .         .       +0.42%      -0.76%      -0.19%    +0.47%    -1.88%    +1.30%    +2.63%    -3.37%    -0.13%    -0.47%      .       -3.80%  
 farcry5                             805       +1.91%    +0.19%    +0.09%    -2.99%       .          .         .       +0.26%      -0.40%      +1.38%    +0.25%    -1.60%    -0.13%    +0.05%    -1.15%    -0.03%    -1.13%      .         .     
 god_of_war                          1029      +0.28%    +0.82%    +0.70%    -0.95%       .          .         .       +0.50%      +0.09%      +0.31%    -0.54%    +0.41%    +0.15%    +0.76%    -2.38%    +0.07%    -0.14%      .         .     
 gtav                                2955      +0.05%    +0.39%    +0.29%    -0.40%       .          .         .       -0.12%      -0.07%      +0.97%    -0.39%    +2.11%      .       -0.33%    -1.47%    +0.20%    -0.02%      .         .     
 heaven_d3d9_strict_float_ultra_4xaa 286         .       +0.10%    -0.11%    -0.39%       .          .         .       -0.96%      -0.21%      +0.28%    -1.46%    -1.51%      .       -0.31%    -0.34%    -0.13%    +0.40%      .         .     
 hogwarts_legacy                     887       +0.21%    +0.08%    -0.47%    -0.41%    +5.00%        .         .       -0.29%      -0.11%      +0.05%    +0.08%    +0.06%    +0.37%    -0.30%    -1.03%    -0.01%    +0.21%      .         .     
 horizon_zero_dawn                   1800      +0.24%    +0.48%    +0.30%    -0.36%       .          .         .       +0.12%      -0.06%      +0.57%    -1.13%    +0.39%      .       -0.55%    -0.79%    +0.03%    +1.32%      .         .     
 madmax                              922       +0.03%    +0.43%    +0.36%    -0.11%       .          .         .       -0.56%      -0.05%      -0.08%    -0.23%    +3.13%      .       +0.12%    -1.37%    +0.23%    +0.39%      .         .     
 metro_exodus                        2627      +0.09%    +0.28%    +0.23%    -0.23%       .          .         .       -0.94%      -0.21%      -0.57%    +3.62%    +0.85%    +0.01%    +0.03%    -1.73%    +0.01%    +0.58%      .       +3.63%  
 PERCENTAGE DELTAS                   Shaders  MaxWaves   Instrs   CodeSize   VGPRs   SpillSGPRs SpillVGPRs  Scratch   Latency  InvThroughput  VClause   SClause    Copies   Branches  PreSGPRs  PreVGPRs    VALU      SALU      VMEM      VOPD   
 monster_hunter_world                1103      -0.06%    +0.51%    +0.42%    -0.18%       .          .         .       +0.16%      +0.20%      +0.01%    +0.36%    +1.36%    +0.01%    -0.41%    -1.13%    +0.01%    +0.80%      .         .     
 nier                                2422        .       +0.49%    +0.39%    +0.14%       .          .         .       -0.72%      -0.19%      +0.01%    -0.26%    +0.24%      .       -0.18%    -4.14%    -0.01%    +1.15%      .         .     
 no_mans_sky                         1978      -0.11%    +0.37%    +0.40%    -0.36%       .          .         .       -0.44%      -0.20%      -0.17%    +0.38%    -0.14%      .       +0.09%    -0.25%    -0.04%    +0.23%      .         .     
 parallel_rdp                        539         .       +2.31%    +1.44%    -1.37%     -inf%     -22.32%   -21.34%    +5.44%      +4.55%      +4.02%    +0.45%    -1.18%    -0.03%    -1.53%    -5.27%    -0.38%    -0.90%    -3.04%      .     
 persona_5                           1566        .       +0.23%    +0.18%    -0.04%       .          .         .       -0.73%      +0.00%      +0.18%    -0.26%    +0.15%      .       +1.88%    -1.81%    +0.01%    +0.00%      .       +1.79%  
 q2rtx                               48          .       +0.03%    +0.01%    +0.50%       .          .         .       +0.11%      -0.14%      +0.07%    -0.13%    -0.74%    +0.18%    +0.23%    -0.81%    -0.21%    +0.32%      .         .     
 rdr2                                3649      +0.24%    +0.21%    +0.14%    -1.29%    +1.14%        .         .       +0.55%      +0.04%      -0.23%    -0.22%    +0.53%    +0.01%    -0.08%    -1.05%    +0.03%    +0.26%      .       -3.22%  
 redout                              2485      +0.11%    +0.49%    +0.34%    -0.48%       .          .         .       +0.29%      +0.08%      -0.01%    -0.58%    +0.53%      .       +0.07%    -0.36%    +0.07%    +0.42%      .         .     
 resident_evil_village               1157      +0.18%    +0.01%    -0.09%    -0.68%    -59.41%    -3.05%     -3.05%    -0.22%      -0.37%      +0.06%    +4.82%    -2.78%    -0.36%    -5.63%    -1.39%    -0.22%    -1.43%    -0.02%      .     
 second_extinction                   437       -0.06%    +0.14%    +0.05%    -0.32%       .          .         .       +0.19%      +0.09%      +0.20%    -0.07%    +0.58%      .       -0.05%    -0.97%    -0.02%    +0.56%      .         .     
 skyrim_dx9                          3305      +0.01%    +1.08%    +0.83%    -0.02%       .          .         .       +0.10%      -0.11%      -0.05%    +0.71%    -0.28%      .       -0.16%    -0.17%    -0.02%    +1.84%      .         .     
 sniper_elite_5                      4278      +1.87%    +0.08%    -0.04%    -2.00%       .          .         .       -0.19%      -0.79%      -0.06%    +1.51%    -0.40%    -0.00%    -1.19%    -1.71%    -0.07%    +0.01%      .         .     
 sottr                               542       +0.72%    +0.51%    +0.42%    -0.77%       .          .         .       +0.06%      -0.10%      -0.41%    +0.56%    +0.69%    +0.01%    -0.59%    -4.46%    +0.02%    +1.04%      .         .     
 spiderman_remastered                648       +1.15%    +0.79%    +0.66%    -1.69%       .          .         .       +0.68%      -1.31%      -0.67%    -0.04%    +0.25%      .       +0.21%    -1.65%    +0.01%    +0.09%      .       -6.67%  
 talos_principle                     1999      +0.01%    +0.12%    +0.10%    -0.22%       .          .         .       -0.46%      +0.00%      +0.09%    -1.28%    +0.34%      .       +0.43%    -0.02%    +0.03%    -0.09%      .         .     
 the_last_of_us_part1                1198      +0.19%    +0.38%    +0.24%    -0.76%    -13.27%       .         .       -0.01%      -1.54%      +0.33%    +2.67%    -1.58%    +0.03%    -2.21%    -1.02%    -0.12%    +0.04%      .       +1.24%  
 thewitness                          3150      -1.94%    -0.10%    -0.20%    +1.68%       .          .         .       -1.32%      -0.04%      -0.52%    -0.07%    -0.19%      .       +0.02%    +0.69%    -0.01%    -0.02%      .         .     
 total_warhammer_3                   632       +1.34%    +0.70%    +0.51%    -1.21%       .          .         .       +0.40%      -0.23%      +4.24%    +0.10%    +0.57%    -0.09%    +1.60%    -1.11%    -0.01%    +2.45%      .       -2.94%  
 war_thunder                         2100      +0.21%    +0.64%    +0.49%    -0.60%    -11.43%       .         .       +0.06%      -0.25%      +0.28%    -0.01%    +0.51%    +0.01%    -0.18%    -1.27%    +0.04%    +0.77%      .       +6.08%  
 worldofwarships                     2130      -0.01%    +0.40%    +0.25%    +0.11%       .          .         .       -0.23%      +0.03%      +0.01%    -0.00%    +0.89%      .       +0.23%    -0.94%    +0.05%    +0.17%      .         .     
 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 All affected                        73409     +0.18%    +0.43%    +0.30%    -0.73%    -12.97%    -21.41%    -0.41%    -0.02%      -0.58%      +0.43%    +0.56%    -0.05%    +0.10%    -0.13%    -1.25%    -0.02%    +0.28%    -0.04%    +0.74%  
 -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Total                               79242     +0.16%    +0.42%    +0.30%    -0.71%    -12.97%    -21.41%    -0.41%    -0.02%      -0.57%      +0.42%    +0.55%    -0.05%    +0.10%    -0.13%    -1.23%    -0.02%    +0.28%    -0.03%    +0.73%  
Edited by Georg Lehmann

Merge request reports