Skip to content

v3dv: implement VK_EXT_shader_demote_to_helper_invocation

Iago Toral requested to merge itoral/mesa:v3dv_demote_to_helper into main

v3dv: implement VK_EXT_shader_demote_to_helper_invocation

Demoting means that we don't execute any writes to memory but otherwise the invocation continues to execute. Particularly, subgroup operations and derivatives must work.

Our implementation of discard does exactly this by using setmsf to prevent writes for the affected invocations, the only difference for us is that with discard/terminate we want to be more careful with emitting quad loads for tmu operations, since the invocations are not supposed to be running any more and load offsets may not be valid, but with demote the invocations are not terminated and thus we should emit memory reads for them to ensure quad operations and derivatives from invocations that have not been demoted still work.

Since we use the sample mask to implement demotes we can't tell whether a particular helper invocation was originally such (gl_HelperInvocation in GLSL) or was later demoted (OpIsHelperInvocationEXT added with SPV_EXT_demote_to_helper_invocation), so we use nir_lower_is_helper_invocation to take care of this.

Merge request reports