Skip to content

panfrost: Stop implementing ->set_damage_region()

The partial_update() infra is broken and needs fixing at the gallium core level: the BACK_LEFT attachment can be outdated when the user calls KHR_partial_update(), leading to a damage region update on the wrong pipe_resource object. Let's not implement ->set_damage_region() until the core is fixed to handle that properly.

Note that we should probably also kill the Lima implementation and revert the DRI2 -> gallium glue exposing this feature to gallium drivers, but I've pinged lima maintainers several times and still didn't have a reply, so I'm opting for this patch that only solves the problem for Panfrost.

For the record, the original revert (the one that broke Lima build) is here [1]. I also sent an RFC [2] that was solving the problem in a hack-ish way, but couldn't find a solution that would work without passing a DRIContext to ->set_damage_region(). Would be great if DRI/Gallium experts (@mareko?) could help me with that.



/cc @alyssa @tomeu @anarsoul @yuq825 @daniels @mareko

[1]bbrezillon/mesa@19546108 [2]

Edited by Boris Brezillon

Merge request reports